WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#49248 closed defect (bug) (fixed)

i18n: add missing placeholders to translators comment

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: administration Cc:

Description

Translators comment best practice is to show the placeholder type when describing what the placeholder replaces inside the translators comment.

Some translators comment are missing the %s placeholders indicators.

The attached patch fixes that.

Attachments (1)

49248.patch​ (4.3 KB) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (4)

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.4

#3 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47093:

I18N: Add missing placeholders to some translators comments in wp-admin.

Props ramiy.
Fixes #49248.

Note: See TracTickets for help on using tickets.