Context Navigation

← Previous Ticket
Next Ticket →

#49249 closed defect (bug) (fixed)

i18n: add translators comment to Media Element translation strings

Reported by:	ramiy	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.4
Component:	I18N	Version:
Severity:	normal	Keywords:	has-screenshots has-patch
Cc:		Focuses:	javascript, administration

Description

Media Element has 3 translation strings with %1 placeholders.

The attached patch adds translators comment to those strings.

Attachments (2)

49249.png (20.4 KB ) - added by ramiy 6 years ago.
49249.patch (1.6 KB ) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
6 years ago

Attachment 49249.png added

@ramiy
6 years ago

Attachment 49249.patch added

#1 @ramiy
6 years ago

Keywords has-screenshots has-patch added

#2 @ramiy
6 years ago

We should also consider replacing %1 with %s.

#3 @SergeyBiryukov
6 years ago

Milestone Awaiting Review → 5.4

These strings were previously removed in [43345] / #42139 and accidentally reintroduced in [44163].

They are unused and should be removed again.

#4 @SergeyBiryukov
6 years ago

Resolution → fixed
Status assigned → closed

In 47094:

I18N: Synchronize MediaElement.js translation strings with the currently bundled version.

Some strings were previously removed in [43345] and accidentally reintroduced in [44163].

Props ramiy.
Fixes #49249. See #42139, #37453.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#49249 closed defect (bug) (fixed)

i18n: add translators comment to Media Element translation strings

Description

Attachments (2)

Change History (6)

@ramiy 6 years ago

@ramiy 6 years ago

#1 @ramiy 6 years ago

#2 @ramiy 6 years ago

#3 @SergeyBiryukov 6 years ago

#4 @SergeyBiryukov 6 years ago

Download in other formats:

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

#2 @ramiy
6 years ago

#3 @SergeyBiryukov
6 years ago

#4 @SergeyBiryukov
6 years ago