WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#49249 closed defect (bug) (fixed)

i18n: add translators comment to Media Element translation strings

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: javascript, administration Cc:

Description

Media Element has 3 translation strings with %1 placeholders.

The attached patch adds translators comment to those strings.

Attachments (2)

49249.png​ (20.4 KB) - added by ramiy 6 years ago.
49249.patch​ (1.6 KB) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-screenshots has-patch added

#2 @ramiy
6 years ago

We should also consider replacing %1 with %s.

#3 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.4

These strings were previously removed in [43345] / #42139 and accidentally reintroduced in [44163].

They are unused and should be removed again.

#4 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47094:

I18N: Synchronize MediaElement.js translation strings with the currently bundled version.

Some strings were previously removed in [43345] and accidentally reintroduced in [44163].

Props ramiy.
Fixes #49249. See #42139, #37453.

Note: See TracTickets for help on using tickets.