i18n: replace %s placeholder type in wp-admin/includes/ms.php

[ramiy]

In the attached patch, a translation string has only one placeholder replaced with the site title.

The patch replaces %1$s with %s, as the string has only one placeholder.

[SergeyBiryukov]

Thanks for the patch!

%1$s is used here so that we don't have to pass $blog_name to sprintf() twice to avoid a "Too few arguments" PHP warning. With the patch, %s is used twice in the string, so we'll also have to pass $blog_name twice.

There are at least two other places in core with the same approach:

• tags/5.3.2/src/wp-admin/includes/misc.php?marks=128,130,134#L125​
• tags/5.3.2/src/wp-admin/includes/network.php?marks=247-249#L233​

I don't see a significant benefit in breaking existing translations here just to change the placeholder.

[ramiy]

Ok, I understand.

Thank you for taking the time to investigate this.