Opened 7 years ago
Closed 7 years ago
#49250 closed defect (bug) (wontfix)
i18n: replace %s placeholder type in wp-admin/includes/ms.php
| Reported by: | ramiy | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | I18N | Version: | |
| Severity: | normal | Keywords: | has-screenshots has-patch |
| Cc: | Focuses: | administration, multisite |
Description
In the attached patch, a translation string has only one placeholder replaced with the site title.
The patch replaces %1$s with %s, as the string has only one placeholder.
Attachments (2)
Change History (6)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Thanks for the patch!
%1$sis used here so that we don't have to pass$blog_nametosprintf()twice to avoid a "Too few arguments" PHP warning. With the patch,%sis used twice in the string, so we'll also have to pass$blog_nametwice.There are at least two other places in core with the same approach:
I don't see a significant benefit in breaking existing translations here just to change the placeholder.