Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#49254 closed defect (bug) (fixed)

Twenty Twenty: Author Bio/Post Meta Width in Cover Template in Mobile

Reported by: jarretc's profile JarretC Owned by: ianbelanger's profile ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords:
Focuses: css Cc:

Description

Currently when the cover template is assigned to a post and the author bio is shown along with the post meta the width of the elements span across the entire browser width in smaller browser widths:

https://i.snipboard.io/bHPx8A.jpg

The .post-inner DIV the elements are confined within on the Cover Template spans across the entire width of the browser whereas in the Default/Full Width templates the .section-inner element has width: calc( 100% - 4rem ); set

Attachments (2)

49254.patch (504 bytes) - added by JarretC 5 years ago.
Sets proper width on mobile cover template for author/post meta elements
49254.1.diff (1.3 KB) - added by ianbelanger 5 years ago.
Update the patch to include RTL styles

Download all attachments as: .zip

Change History (7)

@JarretC
5 years ago

Sets proper width on mobile cover template for author/post meta elements

#1 @JarretC
5 years ago

Proper alignment after patch implementation

https://i.snipboard.io/BRS5tF.jpg

@ianbelanger
5 years ago

Update the patch to include RTL styles

#2 @ianbelanger
5 years ago

  • Focuses css added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.4
  • Version set to 5.3

Thanks for the patch @JarretC. While your solution does fix the issue, your patch did not include the RTL styles. After any changes are made to any CSS file, npm run build needs to be run in order to regenerate the RTL stylesheet. My new patch does that and it also includes another RTL change that was missed in a previous patch.

Last edited 5 years ago by ianbelanger (previous) (diff)

#3 @ianbelanger
5 years ago

  • Owner set to ianbelanger
  • Resolution set to fixed
  • Status changed from new to closed

In 47241:

Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile.

Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.

#4 @ianbelanger
5 years ago

  • Keywords fixed-major added; has-patch commit removed
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#5 @audrasjb
5 years ago

  • Keywords fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.

Note: See TracTickets for help on using tickets.