WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 44 hours ago

#49268 new defect (bug)

Broken themes should always be listed

Reported by: johnbillion Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Themes Keywords: good-first-bug needs-patch
Focuses: administration Cc:

Description

The list of broken themes on the Appearance screen only appears if the user can edit themes (current_user_can( 'edit_themes' )). This means if DISALLOW_FILE_MODS is set to true then the list of broken themes doesn't appear, which is confusing if the user knows for a fact there is a broken theme present.

The list should always been shown. The Delete and Install parent theme buttons should be hidden or shown depending on the edit_themes capability.

Attachments (1)

49268.diff (459 bytes) - added by rebasaurus 4 days ago.
Remove capability check on displaying broken themes

Download all attachments as: .zip

Change History (3)

@rebasaurus
4 days ago

Remove capability check on displaying broken themes

#1 @rebasaurus
4 days ago

  • Keywords has-patch added; needs-patch removed

#2 @johnbillion
44 hours ago

  • Keywords needs-patch added; has-patch removed

Thanks for the patch @rebasaurus! This needs some more work to account for the Delete and Install parent theme buttons as mentioned in the summary.

Note: See TracTickets for help on using tickets.