WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #49288, comment 72


Ignore:
Timestamp:
07/29/2020 07:08:52 PM (4 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #49288, comment 72

    initial v1  
    44Yes, looking more now, some of the js changes would need tweaking/fixing.
    55
    6 > - Previously, the `empty-container` class set via JS was used only on the Dashboard and in the `#post-body` layout only for the `side-sortables`, only in the 2 columns layout.
     6> Previously, the `empty-container` class set via JS was used only on the Dashboard and in the `#post-body` layout only for the `side-sortables`, only in the 2 columns layout.
    77> ...
    8 > - The lack of a min-height is the reason why it was not possible any longer to move a postbox into the `advanced-sortables` area when empty: this was a bug, see comment:7
     8> The lack of a min-height is the reason why it was not possible any longer to move a postbox into the `advanced-sortables` area when empty: this was a bug, see comment:7
    99
    1010Right. The drop areas on the old Edit Post screen are actually three. However the second and third are always shown together. If I remember correctly the reason the third is three is that postboxes added by plugins were put by default in it; at the bottom under the editor. Also think at some point (over 10 years ago) that area used to be shown separately, but now is always shown together with the second area. So when dragging of postboxes was added to that screen, the three areas were kept as back-compat, but the third was (mostly) disabled. The users could drag boxes out but there's no reason for them to add boxes back in it, as they would show and work in exactly the same way as when in the second area. In that terms the changes here can either maintain the previous behavior or make the third area "droppable" again. This won't change how the screen works.