WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#49297 new defect (bug)

Twenty Twenty theme "Clearing Floats" issue

Reported by: fahimmurshed Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: needs-patch
Focuses: css Cc:

Description

Please check "Clearing Floats" by ThemeUnitTest xml file.

Go to /wp-content/themes/twentytwenty/style.css:2607

Change

margin-top:2em;

to

margin-top: 10em;

Screenshot:

Attachments (2)

1.PNG (103.9 KB) - added by fahimmurshed 4 weeks ago.
2.PNG (90.7 KB) - added by fahimmurshed 4 weeks ago.

Download all attachments as: .zip

Change History (8)

@fahimmurshed
4 weeks ago

@fahimmurshed
4 weeks ago

#1 @joyously
4 weeks ago

This was supposedly fixed back in September. See https://github.com/WordPress/twentytwenty/issues/204
Perhaps other changes have brought it back? Or the margins are not applied except in .entry-content?

#2 @SergeyBiryukov
4 weeks ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-unit-tests removed

#3 @ianbelanger
4 weeks ago

  • Focuses css added
  • Version changed from 5.3.2 to 5.3

#4 @ianbelanger
4 weeks ago

  • Keywords needs-patch added; needs-testing removed
  • Milestone changed from Awaiting Review to Future Release

I can confirm the issue does still exist. However, the solution that you suggest @fahimmurshed will only work if the image is a particular size, and if there is no floated image at the end, then the margin is to big. We definitely need to find a fix for this though.

#5 @fahimmurshed
3 weeks ago

Thanks so much, Ian.

I'll find more issues.

#6 @fahimmurshed
3 weeks ago

@ianbelanger,

Got a few ERROR on the Theme Sniffer. Can you please check with Theme Sniffer plugin?

Note: See TracTickets for help on using tickets.