Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#49319 closed defect (bug) (fixed)

Admin triggered download of personal data export give notice of user sent link which is invalid

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: garrett-eclipse's profile garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch has-screenshots has-copy-review commit needs-testing
Focuses: ui, administration, ui-copy Cc:

Description (last modified by garrett-eclipse)

In the list table for the export requests the admin can 'Download Personal Data' from a row action. This triggers a notice stating The personal data export link for this user was sent. which is misleading as no link was sent. Instead this message when the action is triggered from the row-actions should state The personal data export for this user has been downloaded.

Attachments (3)

bba57c2d74d83d732e6e4fa386a4a6c5.gif (74.4 KB) - added by garrett-eclipse 4 years ago.
GIF illustrating the row action and it's resultant notice. The file is downloaded when the link it clicked and no email aside from the original confirmation email is sent through this action.
49319.diff (594 bytes) - added by garrett-eclipse 3 years ago.
Initial Patch to provide "The personal data export file for this user was downloaded." verbiage on download
71d62e697bbc295b55d85715a1082c60.gif (94.9 KB) - added by garrett-eclipse 3 years ago.
New notice verbiage on download which states download.

Download all attachments as: .zip

Change History (13)

@garrett-eclipse
4 years ago

GIF illustrating the row action and it's resultant notice. The file is downloaded when the link it clicked and no email aside from the original confirmation email is sent through this action.

#1 @garrett-eclipse
4 years ago

  • Description modified (diff)

@garrett-eclipse
3 years ago

Initial Patch to provide "The personal data export file for this user was downloaded." verbiage on download

@garrett-eclipse
3 years ago

New notice verbiage on download which states download.

#2 @garrett-eclipse
3 years ago

  • Focuses administration ui-copy added
  • Keywords has-patch needs-testing has-screenshots needs-copy-review added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to garrett-eclipse
  • Status changed from new to accepted

I've uploaded an initial patch in 49319.diff to conditionally change the verbiage to be more appropriate when downloading. New verbiage;
The personal data export file for this user was downloaded.

Just needs testing, copy review and should be good for 5.6.

This ticket was mentioned in Slack in #core-privacy by hellofromtonya. View the logs.


3 years ago

#4 @bridgetwillard
3 years ago

Original

'The personal data export file for this user was downloaded.'

In copywriting, we try to stay away from the passive voice.

With that said, if most of the notices in WordPress are in the passive voice, keep it.

Suggested Revisions

Passive Voice:

'This user's personal data export file was downloaded."

Active Voice:

'You downloaded this users's personal data export file.'

#5 @bridgetwillard
3 years ago

  • Keywords has-copy-review added; needs-copy-review removed

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 years ago

#7 follow-up: @garrett-eclipse
3 years ago

  • Keywords commit added

Thanks very much for the feedback @bridgetwillard and for sparking a lively discussion in core. Until the team finalizes WP's specific guidelines I think we should look to Google developer documentation style guide for this one;
https://developers.google.com/style/voice

Specifically this exception;

To emphasize an object over an action.
Recommended: The file is saved.

As the 'personal data export file' is the object we're emphasizing here I feel we go with what we have which make that the focus.

This also aligns with the string this new one is based off of;
'The personal data export link for this user was sent.'

Once WP settles on voice I'm sure we'll revisit the entire interface and these strings among them.

One further improvement I was going to make but feel is more an enhancement, as it requires updates to function signatures, is replacing this user with the users actual email. When I went to create a ticket I found we have #47491 which already has this suggestion as it will move the notice out of the row to it's normal position so there'll be more of a need to correlate which notice is for which request.

This is ready for commit in my eyes.

#8 in reply to: ↑ 7 @bridgetwillard
3 years ago

Agreed. I like Google's Dev Guide. We should go with the passive.

'This user's personal data export file was downloaded.'

Thanks!

Replying to garrett-eclipse:

Thanks very much for the feedback @bridgetwillard and for sparking a lively discussion in core. Until the team finalizes WP's specific guidelines I think we should look to Google developer documentation style guide for this one;
https://developers.google.com/style/voice

Specifically this exception;

To emphasize an object over an action.
Recommended: The file is saved.

As the 'personal data export file' is the object we're emphasizing here I feel we go with what we have which make that the focus.

This also aligns with the string this new one is based off of;
'The personal data export link for this user was sent.'

Once WP settles on voice I'm sure we'll revisit the entire interface and these strings among them.

One further improvement I was going to make but feel is more an enhancement, as it requires updates to function signatures, is replacing this user with the users actual email. When I went to create a ticket I found we have #47491 which already has this suggestion as it will move the notice out of the row to it's normal position so there'll be more of a need to correlate which notice is for which request.

This is ready for commit in my eyes.

#9 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49289:

Privacy: Use more appropriate verbiage when downloading personal data export file from a row action.

Props garrett-eclipse, bridgetwillard.
Fixes #49319.

#10 @garrett-eclipse
3 years ago

Appreciated @SergeyBiryukov and thanks for catching @bridgetwillard's last copy comment there, I'd overlooked there was a refresh needed.

Note: See TracTickets for help on using tickets.