WordPress.org

Make WordPress Core

Opened 9 months ago

Last modified 6 days ago

#49319 accepted defect (bug)

Admin triggered download of personal data export give notice of user sent link which is invalid

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch needs-testing has-screenshots has-copy-review
Focuses: ui, administration, ui-copy Cc:

Description (last modified by garrett-eclipse)

In the list table for the export requests the admin can 'Download Personal Data' from a row action. This triggers a notice stating The personal data export link for this user was sent. which is misleading as no link was sent. Instead this message when the action is triggered from the row-actions should state The personal data export for this user has been downloaded.

Attachments (3)

bba57c2d74d83d732e6e4fa386a4a6c5.gif (74.4 KB) - added by garrett-eclipse 9 months ago.
GIF illustrating the row action and it's resultant notice. The file is downloaded when the link it clicked and no email aside from the original confirmation email is sent through this action.
49319.diff (594 bytes) - added by garrett-eclipse 4 weeks ago.
Initial Patch to provide "The personal data export file for this user was downloaded." verbiage on download
71d62e697bbc295b55d85715a1082c60.gif (94.9 KB) - added by garrett-eclipse 4 weeks ago.
New notice verbiage on download which states download.

Download all attachments as: .zip

Change History (8)

@garrett-eclipse
9 months ago

GIF illustrating the row action and it's resultant notice. The file is downloaded when the link it clicked and no email aside from the original confirmation email is sent through this action.

#1 @garrett-eclipse
9 months ago

  • Description modified (diff)

@garrett-eclipse
4 weeks ago

Initial Patch to provide "The personal data export file for this user was downloaded." verbiage on download

@garrett-eclipse
4 weeks ago

New notice verbiage on download which states download.

#2 @garrett-eclipse
4 weeks ago

  • Focuses administration ui-copy added
  • Keywords has-patch needs-testing has-screenshots needs-copy-review added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to garrett-eclipse
  • Status changed from new to accepted

I've uploaded an initial patch in 49319.diff to conditionally change the verbiage to be more appropriate when downloading. New verbiage;
The personal data export file for this user was downloaded.

Just needs testing, copy review and should be good for 5.6.

This ticket was mentioned in Slack in #core-privacy by hellofromtonya. View the logs.


6 days ago

#4 @bridgetwillard
6 days ago

Original

'The personal data export file for this user was downloaded.'

In copywriting, we try to stay away from the passive voice.

With that said, if most of the notices in WordPress are in the passive voice, keep it.

Suggested Revisions

Passive Voice:

'This user's personal data export file was downloaded."

Active Voice:

'You downloaded this users's personal data export file.'

#5 @bridgetwillard
6 days ago

  • Keywords has-copy-review added; needs-copy-review removed
Note: See TracTickets for help on using tickets.