#49323 closed enhancement (fixed)
Convert "buttons" to "links" visually on Privacy Export/Erasure "Next Steps" column
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Privacy | Keywords: | has-patch has-screenshots has-dev-note |
Focuses: | ui | Cc: |
Description
As noted in #44264 (comment #12) by @karmatosed we should take a look on converting from Buttons to Links at least visually on the Next Steps columns.
I do agree with this as well as when you are starting to have a list of 5-10-20 ( I've seen way more :D ) exports/erasures the secondary buttons are becoming overwhelming as they are stacked on top of each other.
Attachments (3)
Change History (17)
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
3 years ago
#4
@
3 years ago
- Keywords needs-design-feedback removed
I really prefer this, thanks for working on it. I'll remove the design feedback label and let's get this iteration in.
#5
@
3 years ago
- Keywords 2nd-opinion needs-testing removed
- Owner set to xkon
- Status changed from new to assigned
Awesome! Thanks for the feedback :-).
Note: We'll need #44264 first to go in and this ticket will then need a refresh as there will be some minor conflicts due to the percentage change and they can't be applied together.
As soon as the commit is done I'll quickly refresh this to get it in as well.
#6
@
3 years ago
Thanks @xkon, this works nicely. I appreciate the update. I'll hold on marking commit as you mentioned it's better to have #44264 go first.
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
3 years ago
#9
@
3 years ago
@xkon: I see the .updating-message
class removed in 49323.diff, but not in 49323.2.diff.
It's removed in [47247]. Should it be restored?
#10
follow-up:
↓ 11
@
3 years ago
Whoops! No it should not be re-added. I guess I forgot about it on the refresh 😓 sorry.
The commit looks fine as is!
#11
in reply to:
↑ 10
@
3 years ago
Replying to xkon:
Whoops! No it should not be re-added. I guess I forgot about it on the refresh 😓 sorry.
No worries! Thanks for the confirmation, that's what I figured :) In my testing, it didn't seem to affect anything without the .button
class.
49323.diff changes the previous viewed buttons into links. Unfortunately due to the nature of the actions, some remain as <button> and some are actual <a href>, that's something that we might want to deal with in the future to fully support a11y as well here maybe via Speak also since the context is changing.
I'll also add a need-testings just in case I'm missing anything from the functionality although it's purely classes that have been added & removed :).
I'm definitely +1 on this change, the UI looks way cleaner.