WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 8 weeks ago

#49323 closed enhancement (fixed)

Convert "buttons" to "links" visually on Privacy Export/Erasure "Next Steps" column

Reported by: xkon Owned by: xkon
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-patch has-screenshots has-dev-note
Focuses: ui, privacy Cc:

Description

As noted in #44264 (comment #12) by @karmatosed we should take a look on converting from Buttons to Links at least visually on the Next Steps columns.

I do agree with this as well as when you are starting to have a list of 5-10-20 ( I've seen way more :D ) exports/erasures the secondary buttons are becoming overwhelming as they are stacked on top of each other.

Attachments (3)

49323.diff (4.5 KB) - added by xkon 4 months ago.
49323_preview.gif (595.0 KB) - added by xkon 4 months ago.
49323.2.diff (4.7 KB) - added by xkon 4 months ago.

Download all attachments as: .zip

Change History (16)

@xkon
4 months ago

@xkon
4 months ago

#1 @xkon
4 months ago

  • Keywords needs-testing needs-design-feedback added

49323.diff changes the previous viewed buttons into links. Unfortunately due to the nature of the actions, some remain as <button> and some are actual <a href>, that's something that we might want to deal with in the future to fully support a11y as well here maybe via Speak also since the context is changing.

I'll also add a need-testings just in case I'm missing anything from the functionality although it's purely classes that have been added & removed :).

I'm definitely +1 on this change, the UI looks way cleaner.

#2 @SergeyBiryukov
4 months ago

  • Component changed from General to Privacy

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


4 months ago

#4 @karmatosed
4 months ago

  • Keywords needs-design-feedback removed

I really prefer this, thanks for working on it. I'll remove the design feedback label and let's get this iteration in.

#5 @xkon
4 months ago

  • Keywords 2nd-opinion needs-testing removed
  • Owner set to xkon
  • Status changed from new to assigned

Awesome! Thanks for the feedback :-).

Note: We'll need #44264 first to go in and this ticket will then need a refresh as there will be some minor conflicts due to the percentage change and they can't be applied together.

As soon as the commit is done I'll quickly refresh this to get it in as well.

#6 @garrett-eclipse
4 months ago

Thanks @xkon, this works nicely. I appreciate the update. I'll hold on marking commit as you mentioned it's better to have #44264 go first.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


4 months ago

@xkon
4 months ago

#8 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47247:

Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.

With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.

#9 @SergeyBiryukov
4 months ago

@xkon: I see the .updating-message class removed in 49323.diff, but not in 49323.2.diff.

It's removed in [47247]. Should it be restored?

#10 follow-up: @xkon
4 months ago

Whoops! No it should not be re-added. I guess I forgot about it on the refresh 😓 sorry.

The commit looks fine as is!

#11 in reply to: ↑ 10 @SergeyBiryukov
4 months ago

Replying to xkon:

Whoops! No it should not be re-added. I guess I forgot about it on the refresh 😓 sorry.

No worries! Thanks for the confirmation, that's what I figured :) In my testing, it didn't seem to affect anything without the .button class.

This ticket was mentioned in Slack in #accessibility by pbiron. View the logs.


8 weeks ago

Note: See TracTickets for help on using tickets.