#49334 closed enhancement (fixed)
[Theme compatibility] WP/PHP compatibility testing for theme activation
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 5.5 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Site Health | Keywords: | has-patch early has-screenshots has-dev-note |
| Focuses: | administration | Cc: |
Description (last modified by )
Attachments (4)
Change History (20)
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
#4
@
5 years ago
- Description modified (diff)
- Keywords has-patch added; needs-patch removed
- Summary changed from [Theme compatibility] WP/PHP compatibility testing for theme installation to [Theme compatibility] WP/PHP compatibility testing for theme activation
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
@
4 years ago
Alternative patch: remove <strong>Errors:</strong> from wp_die() as users already know we have an error.
#8
@
4 years ago
- Keywords has-screenshots added; dev-feedback removed
Hi there,
I tested this patch and it works fine to me. Let's add a commit keyword as it need to be committed early.
I also added an alternative patch which remove <strong>Errors:</strong> from wp_die() as users may already know there is an error. See ticket #47656 also slated to milestone 5.5.
#10
@
4 years ago
The wp_die message should be consistent with the same message for plugin incompatibility r44978
#11
@
4 years ago
Yep then let’s commit 49334.diff as it and fix the issue with error messages in #47656 🚀
Pinging @pento as the Upgrade/Install maintainer.
I'm having trouble getting into the data element in the script tag so that I can make the compatibility tests. Any pointers would be appreciated. Thanks.