WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #49348, comment 7


Ignore:
Timestamp:
02/05/2020 11:32:59 AM (5 years ago)
Author:
andraganescu
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #49348, comment 7

    initial v1  
    11Regarding the two functions mentioned by @TimothyBlynJacobs `build_css_colors` and `build_css_font_sizes` these are needed to extract color and font size CSS class / data because the block is using the new colors and fonts hooks.
    22
    3 While working on adding features to the `PostAuthor` block I have also needed the same functions and, for reasons of moving the PR ahead, just copied them, see the GitHub issue [#19894 https://github.com/WordPress/gutenberg/pull/19894]
     3While working on adding features to the `PostAuthor` block I have also needed the same functions and, for reasons of moving the PR ahead, just copied them, see the GitHub issue [https://github.com/WordPress/gutenberg/pull/19894 19894]
    44
    55What would the solution be to have these as reusable code? Should we?