WordPress.org
Get WordPress

Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#4935 closed defect (bug) (fixed)

Pagination is broken

Reported by: matt's profile matt Owned by:
Milestone: 2.3 Priority: normal
Severity: blocker Version: 2.3
Component: General Keywords: has-patch
Focuses: Cc:

Description

The links on (for example) the edit-comments.php are like:

edit-comments.php?apage=%25%23%25

The arguments to paginate_links were getting encoded by add_query_arg.

Attachments (1)

pagination.diff​ (408 bytes) - added by matt 18 years ago.
This fixes it.

Download all attachments as: .zip

Change History (8)

@matt
18 years ago

This fixes it.

#1 @matt
18 years ago

  • Keywords has-patch added

Patch attached, but not sure if that's the best fix.

#2 @markjaquith
18 years ago

I think we should probably just forget about http_build_query and use our compat function (which can have the urlencoding turned off). I'll give that a shot.

#3 @markjaquith
18 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6064]) Only urlencode previously existing values in add_query_arg() (more backwards compatible). fixes #4935. see #4084. see #4878

#4 @mdawaffe
18 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

$lsb and friends are never actually used in this patch. Intentional, or should line 123 change?

#5 @markjaquith
18 years ago

(In [6069]) Forgot to use $lsb and $rsb in [6064]. Props mdawaffe. see #4935. see #4878

#6 @markjaquith
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks. Had that in there at one point. Must have gotten greedy with Cmd-Z after going down a few dead end paths. ;-)

#7 @markjaquith
18 years ago

(In [6070]) Actually, we always need to URLencode square brackets... or wp_redirect() will strip them out. see #4935. see #4878

Note: See TracTickets for help on using tickets.