Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#49353 closed defect (bug) (fixed)

button padding issue in edit plug on small device

Reported by: passoniate Owned by: afercia
Priority: normal Milestone: 5.4.2
Component: Editor Version: 5.4
Severity: normal Keywords: has-screenshots has-patch fixed-major
Cc: Focuses: ui, css

Description

button padding issue in edit plug on small device

Attachments (5)

editor-button.png (20.7 KB ) - added by passoniate 7 years ago.
49353.patch (524 bytes ) - added by garethgillman 7 years ago.
removes bottom and top padding under 782px
49353.diff (507 bytes ) - added by afercia 6 years ago.
49353 Look Up.png (73.7 KB ) - added by afercia 6 years ago.
Look Up button with the patch applied in the responsive view
49353 Select.png (44.9 KB ) - added by afercia 6 years ago.
Select files button with the patch applied in the responsive view

Download all attachments as: .zip

Change History (12)

#1 @passoniate
7 years ago

@afercia

@garethgillman
7 years ago

removes bottom and top padding under 782px

#2 @afercia
6 years ago

  • Keywords has-patch added

Looks like the submit button was already fixed in [47071] / #49197. Though, I don't see any reason why it should have a left/right padding of 18px. There shouldn't be exceptions to the default buttons styles.

Last edited 6 years ago by afercia (previous) (diff)

#3 @afercia
6 years ago

  • Milestone Awaiting Review5.4.2

@afercia
6 years ago

#4 @afercia
6 years ago

49353.diff removes the exceptions for the styling of the "Select plugin/theme to edit" and documentation "Look Up" buttons. These buttons should just use the default buttons style.

This ticket seems to me a nice candidate for a point release as it's a regression from 5.3.x, the patch is straightforward and self-contained.

@afercia
6 years ago

Look Up button with the patch applied in the responsive view

@afercia
6 years ago

Select files button with the patch applied in the responsive view

#5 @afercia
6 years ago

  • Owner set to afercia
  • Resolutionfixed
  • Status newclosed

In 47751:

File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.

Buttons should use the default buttons styles, no exceptions.

Props passoniate, garethgillman.
See #49197.
Fixes #49353.

#6 @afercia
6 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closedreopened

Reopening for 5.4.2 consideration.

#7 @whyisjake
6 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 47824:

File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
Buttons should use the default buttons styles, no exceptions.

This commit bring the changes from [47751] to the 5.4 branch.

Props passoniate, garethgillman, @afercia.
See #49197.
Fixes #49353.

Note: See TracTickets for help on using tickets.