Provide 'Cancel' when editing widget in accessibility mode

[garrett-eclipse]

Hello,

While playing with the Widgets Accessibility Mode I found there's no easy way to cancel/goback when editing a widget;

On the other hand when adding a widget we do have a cancel option;

It would be nice to provide a cancel button on the edit view to allow you to go back without saving any changes to your widget. Right now to go back/cancel you have to go to the menu and select Widgets again.

[garrett-eclipse]

Edit Widget only provides 'Delete' and 'Save'

[garrett-eclipse]

Add widget does provide 'Cancel'

[garrett-eclipse]

Do note, the cancel button on the Add Widget screen looks identical aside from text to the delete button on the Edit Widget screen.
Might be a good idea to have Delete marked in red to indicate it removes the widget losing all settings, then the cancel can be added in the style we find on Add Widget screen.

[afercia]

This ticket was discussed during today's accessibility bug-scrub: sounds sensible. Moving to Future release. As it's a small, self-contained, fix this can likely go into 5.5 is a patch comes to life.

[garrett-eclipse]

Initial patch to introduce cancel to the editing widget screen within accessibility mode

[garrett-eclipse]

Updated Edit Screen w/ new Cancel link

[garrett-eclipse]

Updated Add Screen switching cancel button to link

[garrett-eclipse]

Non-accessibility mode edit widget showing button links which I followed to conform to convention

[garrett-eclipse]

Thanks @afercia I've created an initial patch in 49354.diff if you and @audrasjb can test/review maybe we can milestone for 5.5.

Notes on the patch;

• I followed the convention of the non-accessible widget edit screen and used the button-link approach.
• I kept the term Cancel instead of using Done. Done is what the term is on the non-accessible widget, personally I feel Cancel there makes more sense...
• I copied the widget-control-close-wrapper and widget-control-close classes but wonder if we should if widget-control-cancel is more appropriate
• I didn't change the Cancel button found when adding a widget in the non-accessible view to a link, it's left as a button.

Thoughts?

[audrasjb]

Widgets: Accessibility: Introduce cancel button in Widgets screen accessibility mode’s widget editor

[audrasjb]

Testing 49354.1.diff

[audrasjb]

Thanks for the patch, @garrett-eclipse

I refreshed it. Looks like a great enhancement!
Patch works fine. Let's add this enhancement in 5.6 milestone.

[afercia]

Worth reminding that in WordPress 5.6 the old Widgets screen will be replaced with the new block-based one. When activating the Gutenberg plugin, the old page gets already entirely replaced. I heard there should be a way to disable the new screen. Maybe via a filter? Not sure.

[garrett-eclipse]

Thanks @afercia appreciate the heads up, if this ticket wasn't ready for commit I'd probably drop it.

As it's good to go I'd say let's commit it and if it's ripped out with the rest of Widgets so be it. But if it sticks around a version or two due to WP providing extended support to the old Widgets screen, like was done with the Classic Editor, then awesome.
Either way happy to have this complete ticket close as fixed rather than be a wontfix.

[afercia]

Sure :)

[SergeyBiryukov]

In 49113:

Accessibility: Widgets: Add a "Cancel" link when editing a widget in accessibility mode.

This allows the user to go back without saving any changes to the widget.

Props garrett-eclipse, audrasjb, afercia.
Fixes #49354.