![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 6 years ago
Closed 6 years ago
#49359 closed defect (bug) (fixed)
Duplicate keys and strings in TinyMCE 3.x language strings
| Reported by: | david.binda | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.4 |
| Component: | TinyMCE | Version: | 5.4 |
| Severity: | minor | Keywords: | |
| Cc: | Focuses: | javascript |
Description
The list of language strings in https://build.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/langs/wp-langs-en.js?annotate=blame&rev=46956#L499 contains 3 duplicate key-value pairs. Specifically the height, css, and orig_size. (se lines 499-501 and lines 504-506).
While this might not be causing any issues, it, IMHO, should be enough to have the mentioned keys listed only once.
Attachments (1)
Change History (4)
#2
@
6 years ago
Worth noting that most (all?) of these strings appear to be unused since [26876/trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js], and the strings from _WP_Editor::get_translation() are used instead.
That said, I guess it doesn't hurt to leave them as is until a proper investigation is done. Let's just remove the duplicates for now.
Introduced in [8083].