WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#49359 closed defect (bug) (fixed)

Duplicate keys and strings in TinyMCE 3.x language strings

Reported by: david.binda Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: minor Version: 5.4
Component: TinyMCE Keywords:
Focuses: javascript Cc:

Description

The list of language strings in https://build.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/langs/wp-langs-en.js?annotate=blame&rev=46956#L499 contains 3 duplicate key-value pairs. Specifically the height, css, and orig_size. (se lines 499-501 and lines 504-506).

While this might not be causing any issues, it, IMHO, should be enough to have the mentioned keys listed only once.

Attachments (1)

49359.diff (506 bytes) - added by david.binda 4 months ago.

Download all attachments as: .zip

Change History (4)

@david.binda
4 months ago

#1 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Introduced in [8083].

#2 @SergeyBiryukov
4 months ago

Worth noting that most (all?) of these strings appear to be unused since [26876/trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js], and the strings from _WP_Editor::get_translation() are used instead.

That said, I guess it doesn't hurt to leave them as is until a proper investigation is done. Let's just remove the duplicates for now.

#3 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47172:

TinyMCE: Remove duplicate keys and strings from langs/wp-langs-en.js.

Props david.binda.
Fixes #49359.

Note: See TracTickets for help on using tickets.