WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #49364, comment 33


Ignore:
Timestamp:
08/14/2022 08:32:54 PM (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #49364, comment 33

    v1 v2  
    4444See [attachment:"49364.2.diff"] for the suggested solution, which reverts most of [47184] as no longer needed.
    4545
    46 This change is covered by 20+ existing `dbDelta()` tests which currently fail on PHP 8.0.x + MariaDB, and pass with this patch. It also resolves an issue with plugin activation described in comment:5:
     46This change is covered by existing unit tests:
     47* 20+ `dbDelta()` tests which currently fail on PHP 8.0.x + MariaDB and pass with this patch.
     48* One test from the ticket description which currently fails on MySQL 8.0.17+ and passes with this patch.
     49
     50It also resolves an issue with plugin activation described in comment:5:
    4751> The first activation will go without issues. However deactivating and re-activating the plugin attempts to run the following (unnecessary) alter statement:
    4852>