Remove Tests_Post_Types::register_post_type()

[SergeyBiryukov]

[36768] introduced Tests_Post_Types::register_post_type() as a helper for some tests in tests/phpunit/tests/post/types.php.

This method is only used in 6 tests (out of 36 in the file), is redundant, and causes a bit of confusion as to why some tests use that while others use register_post_type() directly.

Since register_post_type() returns the registered post type object on success,

$args = $this->register_post_type( array( ... ) )

can be replaced with:

$args = register_post_type( $this->post_type, array( ... ) );

[varunshanbhag]

Updated 6 test to make them more uniform with other tests for register_post_type

[gh640]

I believe the method Tests_Post_Types::register_post_type() needs to be removed instead of changing only the arguments.

I run the test in my environment after applying the patch and it works well.

This is my first attempt to send a patch here and please let me know if there's anything wrong. Thank you in advance.

[SergeyBiryukov]

Replying to gh640:

This is my first attempt to send a patch here and please let me know if there's anything wrong. Thank you in advance.

49365.2.diff​ looks perfect, thank you :)

[SergeyBiryukov]

In 47381:

Build/Test Tools: Remove redundant Tests_Post_Types::register_post_type() helper method, use register_post_type() directly.

Props gh640, varunshanbhag.
Fixes #49365.

[gh640]

Replying to SergeyBiryukov:

Great! Thank you very much :)