Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #49367, comment 4


Ignore:
Timestamp:
02/05/2020 08:42:29 PM (6 years ago)
Author:
xkon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #49367, comment 4

    v1 v2  
    44https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/tests/dbdelta.php#L478
    55
    6 And the list goes on ( all instances are within the dbdelta.php though so it makes it kinda easier ), should those be updated also in a similar manner? I'm guessing that the assertSame would be failing there if the tables are on InnoDB, correct? Sorry, I missed this before I didn't think of making a full search 😅.
     6And the list goes on ( all instances are within the dbdelta.php though so it makes it kinda easier ), should those be updated also in a similar manner? I'm guessing that if MyISAM isn't supported the dbDelta() itself would fail there also, correct? Sorry, I missed this before I didn't think of making a full search 😅.
    77
    8 Not sure at all on this btw so I'm just asking, tests pass on my end but trying to think if there's something that I'm missing :D
     8Not sure at all on this btw (trying to figure out a way to test this on my end) so I'm just asking :)