WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#49397 closed defect (bug) (fixed)

Block Editor: Update WordPress Packages; Remove navigation block; Add social links block

Reported by: jorgefilipecosta's profile jorgefilipecosta Owned by: jorgefilipecosta's profile jorgefilipecosta
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: General Keywords: has-patch commit
Focuses: Cc:

Description (last modified by gziolo)

The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/scripts: 6.2.0 -> 7.1.0 (removed from the patch)
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0

The navigation block inclusion was reverted.
The social links block was included.

Attachments (5)

49397.diff​ (98.6 KB) - added by jorgefilipecosta 5 years ago.
49397.2.diff​ (161.7 KB) - added by jorgefilipecosta 5 years ago.
49397.3.diff​ (162.3 KB) - added by jorgefilipecosta 5 years ago.
49397.4.diff​ (162.2 KB) - added by jorgefilipecosta 5 years ago.
49397.5.diff​ (135.0 KB) - added by jorgefilipecosta 5 years ago.

Download all attachments as: .zip

Change History (10)

@jorgefilipecosta
5 years ago

@jorgefilipecosta
5 years ago

This ticket was mentioned in ​Slack in #core-editor by jorgefilipecosta. ​View the logs.
5 years ago

@jorgefilipecosta
5 years ago

@jorgefilipecosta
5 years ago

This ticket was mentioned in ​PR #152 on ​WordPress/wordpress-develop by ​jorgefilipecosta.
5 years ago #2

@jorgefilipecosta
5 years ago

#3 @gziolo
5 years ago

  • Description modified (diff)
  • Keywords needs-testing added

Everything looks good code-wise. It tests well for the Social Icons block added.

#4 @noisysocks
5 years ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Awaiting Review to 5.4

I applied 49397.5.diff​, and:

✅ The patch applied cleanly
✅ grunt build ran with no errors
✅ The block editor loaded and was usable
✅ The Navigation block was not available for use
✅ The Social Icons block was available and worked

In other words, LGTM!

Last edited 5 years ago by noisysocks (previous) (diff)

#5 @jorgefilipecosta
5 years ago

  • Owner set to jorgefilipecosta
  • Resolution set to fixed
  • Status changed from new to closed

In 47250:

Block Editor: Update WordPress Packages; Remove navigation block; Add social links block

The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.

Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397.

Note: See TracTickets for help on using tickets.