Make WordPress Core

Opened 5 years ago

Last modified 4 years ago

#49407 new enhancement

Do not propose users to skip a minor upgrade (take 2)

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: ui Cc:

Description

Background: #43242

[47061] removed the suggestion for users to skip a minor update to keep their current translation. With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

There's still some functionality to dismiss a core update, including:

  • "Hide this update" button on WordPress Updates screen.
  • dismissed option in get_core_updates().
  • Some functions:
    • dismissed_updates()
    • dismiss_core_update()
    • undismiss_core_update()

We should re-evaluate whether this functionality should be deprecated, as it goes against the project goals of keeping as many sites up-to-date as possible.

Change History (12)

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#3 @afragen
4 years ago

#51808 was marked as a duplicate.

#4 @afragen
4 years ago

  • Milestone changed from Awaiting Review to 5.7

As this seems very outdated and should be deprecated, would the deprecation simply be a code removal or does some deprecated notice need to be issued.

#5 @audrasjb
4 years ago

  • Focuses ui added

Hi,

I think we should simply deprecate the function using _deprecated_function, remove "Hide this update" button on WordPress Updates screen and remove the dismissed option in get_core_updates() :)

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


4 years ago

#8 @ocean90
4 years ago

I want to note that’s ok to skip/ignore a localized update package if you already have installed the default package. That’s why this functionality exists and probably needs to remain for while.
This also only affects 2-3 locales which still have "complex" packages, meaning the package also contains locale specific plugins/files.

Version 0, edited 4 years ago by ocean90 (next)

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


4 years ago

#12 @SergeyBiryukov
4 years ago

  • Milestone changed from 5.7 to Future Release
Note: See TracTickets for help on using tickets.