WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 8 months ago

Last modified 7 months ago

#49410 closed defect (bug) (fixed)

Twenty Nineteen: Text color setting in pullquote block not applied

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

Text color settings in the pullquote block are not being applied.

To replicate:

  1. With Twenty Nineteen active, create a new post in the block editor
  2. Add a Pullquote block
  3. Add some text and try adjusting the color settings

Attachments (2)

49410.diff (1.4 KB) - added by ianbelanger 9 months ago.
Fixes pullquote color options
49410.1.diff (2.9 KB) - added by ianbelanger 9 months ago.
Includes style.css changes, first npm run build had line ending issues

Download all attachments as: .zip

Change History (10)

#1 @ianbelanger
9 months ago

  • Component changed from General to Bundled Theme

Related #47019 - same issue was reported in Twenty Sixteen

@ianbelanger
9 months ago

Fixes pullquote color options

#2 @ianbelanger
9 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

@ianbelanger
9 months ago

Includes style.css changes, first npm run build had line ending issues

#3 @ianbelanger
8 months ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 5.4
  • Status changed from assigned to reviewing
  • Version set to 5.0

Reviewing for commit.

#4 @ianbelanger
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47339:

Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.

Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.

#5 @ianbelanger
8 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#6 @audrasjb
8 months ago

  • Keywords commit fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.

#7 @SergeyBiryukov
7 months ago

In 47536:

Twenty Nineteen: Update style-rtl.css after [47339].

Props ianbelanger.
See #49410.

#8 @SergeyBiryukov
7 months ago

In 47538:

Twenty Nineteen: Update style-editor.css and style-rtl.css after running the build task.

Follow-up to [47327], [47339].

Props ianbelanger.
Reviewed by desrosj, SergeyBiryukov.
Merges [47536] and [47537] to the 5.4 branch.
See #48526, #49410, #49743.

Note: See TracTickets for help on using tickets.