WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #49431, comment 1


Ignore:
Timestamp:
02/14/2020 07:38:11 AM (5 years ago)
Author:
talldanwp
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #49431, comment 1

    initial v1  
    55https://github.com/WordPress/wordpress-develop/blob/3dd39ffecea808afe86b8071331551d9d5e8cf89/src/js/media/views/uploader/window.js#L30
    66
    7 In #39305 @afercia mentions this button is used by another view UploaderInline, that detaches one of the buttons when the media uploader is opened, and that looks like it's still the case.
     7In #39305 @afercia mentions this button is used by another view UploaderInline, that detaches one of the buttons when the media uploader is opened, and that looks like it's still the case. But if a user never opens the media library, the button is never cleaned up.
    88
    99I'm not clear on why this behaviour exists, so I feel uncomfortable modifying this code. Why does the button get appended to the body first? That's what I'd love to know if anyone has an idea!