WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#49436 closed defect (bug) (fixed)

Add missing package to the default export array

Reported by: jorgefilipecosta's profile jorgefilipecosta Owned by: jorgefilipecosta's profile jorgefilipecosta
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12.
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.

Attachments (1)

49436.diff​ (390 bytes) - added by jorgefilipecosta 5 years ago.

Download all attachments as: .zip

Change History (6)

@jorgefilipecosta
5 years ago

#1 @jorgefilipecosta
5 years ago

cc: @aduth, @gziolo

This ticket was mentioned in ​PR #155 on ​WordPress/wordpress-develop by ​jorgefilipecosta.
5 years ago #2

#3 @SergeyBiryukov
5 years ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 5.4

#4 @aduth
5 years ago

Confirmed that patch works as I expect, with wp.warning available as a function (it's a noop in production build, which is the expected behavior).

wp.warning( 'Hello world' );
// undefined

LGTM 👍

#5 @jorgefilipecosta
5 years ago

  • Owner set to jorgefilipecosta
  • Resolution set to fixed
  • Status changed from new to closed

In 47301:

Block Editor: Add missing package to the default export array.

Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12.
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.

Props gziolo, aduth.
Fixes #49436.

Note: See TracTickets for help on using tickets.