Make WordPress Core

Opened 20 months ago

Last modified 20 months ago

#49438 new defect (bug)

Twenty Twenty: h1 when is_front_page() is a static page — at Version 1

Reported by: SGr33n Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch reporter-feedback
Focuses: Cc:

Description (last modified by SergeyBiryukov)

I see that template-tags.php doesn't assign the h1 to the site title correctly when you assign a static page to the front page.

It's due to the code
'condition' => ( is_front_page() || is_home() ) && ! is_page()

is_page(), infact, returns true on is_front_page() in that case.

I suppose it should be:

'condition' => is_front_page() || ( is_home() && ! is_page() )

Diff patch attached.

Change History (2)

20 months ago

#1 @SergeyBiryukov
20 months ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.