cache the results of get_uploaded_header_images()

[pbiron]

If the current theme supports custom-header and is_random_header_image() is true, then _media_states() calls get_uploaded_header_images() for every row in the media list table.

If the results of get_uploaded_header_images() were cached, the media list table would render much quicker, especially if the number of media displayed per page is large.

There is already an inline comment @todo Caching which has apparently been there since get_uploaded_header_images() was added in [17757].

[SergeyBiryukov]

Replying to pbiron:

If the current theme supports custom-header and is_random_header_image() is true, then _media_states() calls get_uploaded_header_images() for every row in the media list table.

Even with caching added, saving $header_images to a static variable in _media_states() seems like a quick win to avoid having to go through wp_list_pluck() for the result of get_uploaded_header_images() for every row.

[pbiron]

Replying to SergeyBiryukov:

Even with caching added, saving $header_images to a static variable in _media_states() seems like a quick win to avoid having to go through wp_list_pluck() for the result of get_uploaded_header_images() for every row.

Agreed...that's kind how I stumbled on this. I've got a custom plugin that does a relatively complex query hooked to display_media_states and storing the results in a static sped things up considerably.

I went looking for more improvements and was going to suggest exactly the patch you added...then found that inline comment about caching in get_uploaded_header_images() :-)

[SergeyBiryukov]

49446.2.diff​ adds a missing @staticvar entry.

[pbiron]

I wasn't aware of the @staticvar tag, so I went to ​PHP Documentation Standards handbook page and don't see it listed as one of the tags (altho a quick search thru the core source, I see ~100 uses).

The handbook page does have an entry for @static that states:

Note: This tag has been used in the past, but should no longer be used.
Just using the static keyword in your code is enough for PhpDocumentor on PHP5 to recognize static variables and methods, and PhpDocumentor will mark them as static

Should the handbook be updated to mention @staticvar?

p.s. is this ready to commit now?

[SergeyBiryukov]

Replying to pbiron:

I wasn't aware of the @staticvar tag, so I went to ​PHP Documentation Standards handbook page and don't see it listed as one of the tags (altho a quick search thru the core source, I see ~100 uses).
...
Should the handbook be updated to mention @staticvar?

Yes, it's used in core but for some reason not mentioned in the handbook.

Note that it's different from the @static tag that was removed in #42803.

p.s. is this ready to commit now?

I think so :)

[SergeyBiryukov]

Replying to SergeyBiryukov:

Yes, it's used in core but for some reason not mentioned in the handbook.

It turned out the @staticvar tag should not be used :) Follow-up: #50426.

So 49446.diff​ would be the preferred patch here.

[whyisjake]

In 48152:

Cache API: Cache the results of get_uploaded_header_images().

Fixes #49446.

Props pbiron, SergeyBiryukov, desrosj.

[SergeyBiryukov]

The commit message in [48152] is misleading, it provides a performance improvement for _media_states(), but does not actually add caching to get_uploaded_header_images().

I believe there's still benefit in doing the latter, as it's used in some other places.

[desrosj]

Not going to be able to work on this near term. Removing myself as owner so other interested contributors do not hesitate to take this on.

Previously, the get_uploaded_header_images function did not utilize caching, leading to potential performance issues. This commit introduces transient caching to store the header images, significantly improving efficiency. A corresponding PHPUnit test has also been added to verify the caching functionality.

[pbearne]

Add caching for this function it looks like it save 4 DB calls

@pbearne some unit tests are failing. Could you please take a look?

@SergeyBiryukov or @desrosj could one of you please take a look when you have moement. Thanks!

[flixos90]

Just left a review on the PR. It looks good so far in terms of caching logic, but we'll need to also take care of invalidation. This is not something where we should only rely on expiration of the transient, as that would still mean we'd sometimes serve stale values for something that is user-editable.

@pbearne This looks solid in terms of caching logic. However, we also need to make sure that this is invalid when relevant attachments are uploaded/assigned/modified.

Can you implement additional hook callbacks here that delete the transient whenever an attachment is created or assigned to the active theme (via the _wp_attachment_is_custom_header meta key/value), or when such a an attachment is edited?

Have add cache invalidation for the meta I belive that this will also cover if it is edited as this meta will be updated as part of the process

@pbearne Given that 6.7 Beta 1 is tomorrow, we'll have to punt this to 6.8. There's still two outstanding issues here:

• The cache invalidation needs to cater for when the attachment that is currently set as _wp_attachment_is_custom_header gets edited. See ​https://github.com/WordPress/wordpress-develop/pull/7154#pullrequestreview-2323622986.
• The tests are failing when using a persistent object cache.

[flixos90]

Punting this to 6.8, as there are still some issues to address in the PR.

@pbearne Some of the PHPUnit tests are still failing, e.g. ​https://github.com/WordPress/wordpress-develop/actions/runs/11507618643/job/32034197173?pr=7154.

Would you be able to take another look at addressing those? Please let us know if you run into any blockers.

[pbearne]

the tree failers seem to only fail when Memcache is active
So I do not see these errors in my local dev

Do you know a way to run the Memcache tests locally?

[audrasjb]

As per today's bugscrub: as we're getting close to 6.8 beta 1 I'm moving it to milestone 6.9. Please move it back in 6.8 if the PR can be reviewed in the next couple days.