WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4946 closed defect (bug) (fixed)

Duplicate code oddness in wp_insert_attachement

Reported by: Otto42 Owned by:
Milestone: 2.3 Priority: lowest
Severity: trivial Version: 2.3
Component: Optimization Keywords:
Focuses: Cc:

Description

Just noticed this bit of code in SVN:

`
if ( isset($to_ping) )

$to_ping = preg_replace('|\s+|', "\n", $to_ping);

else

$to_ping = ;

`

...is duplicated in the wp_insert_attachment function. Line numbers 1345 and 1363.

Accidental copy/paste, or is there a reason for this that is cleverer than my current ability to fathom?

Change History (3)

comment:1 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6086]) Remove duplicate code from wp_insert_attachment(). Update to use sanitize_post. Props Otto42. fixes #4946

comment:2 ryan7 years ago

Did some more cleanup while I was in there.

comment:3 westi7 years ago

  • Milestone changed from 2.4 to 2.3
Note: See TracTickets for help on using tickets.