Opened 5 years ago
Closed 5 years ago
#49476 closed defect (bug) (fixed)
Incorrect links to export/delete personal data in emails
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3.3 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Privacy | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
When an email is sent to the administrator with a notification of a user requesting the erase or export of their personal data, the links are incorrect.
wp-admin/tools.php?page=export_personal_data
Should be: wp-admin/export-personal-data.php
And wp-admin/tools.php?page=remove_personal_data
should be: wp-admin/erase-personal-data.php
Both links result in a 'Sorry, you are not allowed to access this page' error.
Attachments (1)
Change History (12)
@
5 years ago
Patch to update links in emails and update the back-compat redirects so they aren't blocked by the user_can_access_admin_page check
#3
@
5 years ago
- Keywords has-patch needs-testing added; needs-patch removed
- Milestone changed from Awaiting Review to 5.3.3
- Version set to 5.3
Thanks @jurgen-oldenburg for catching this.
I've updated the links in 49476.diff to point to the new locations.
Also while looking into this I found there was some redirect code in the tools.php which was supposed to mitigate the change by redirecting to the proper new location;
This unfortunately is run after the /wp-admin/admin.php
require which through a later require of wp-admin/includes/menu.php
does a user_can_access_admin_page
check and fails due to the pages no longer existing. To address this I moved the conditional before the require and added wp-load.php
require_once calls in order to have wp_redirect
function.
@SergeyBiryukov I've milestoned for 5.3.3 as this is a reversion introduced on that branch but am wondering if it's not too late for 5.4.
CC @azaozz as the original committer of the privacy re-organization. Mostly wanting to see if my approach to the back-compat redirect is appropriate.
Hi there, welcome to WordPress Trac! Thanks for the report.
Just adding a link to the related changeset here: [45448] / #43895.