WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#49489 closed task (blessed) (fixed)

Introduce a Pull Request Template file

Reported by: desrosj Owned by: desrosj
Priority: normal Milestone: 5.4
Component: General Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

A pull request template file should be added so that users opening pull requests to the Git mirror have proper guidance and expectations after the introduction of GitHub PR linking for Trac tickets (see ​Meta-4903).

Related Make Core post: ​https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/

Attachments (1)

pull-request-template.diff​ (2.0 KB ) - added by desrosj 6 years ago.

Download all attachments as: .zip

Change History (4)

@desrosj
6 years ago

#1 @desrosj
6 years ago

  • Owner set to desrosj
  • Resolution → fixed
  • Status new → closed

In 47342:

General: Introduce a pull request template.

This ensures that contributors opening a pull request on GitHub for code review have proper guidance.

See ​https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and ​https://meta.trac.wordpress.org/ticket/4903.

Props noisysocks, desrosj.
Fixes #49489.

#2 @desrosj
6 years ago

This was a first pass at this file. Please open follow up tickets for suggested changes.

#3 @kraftbj
6 years ago

#49498 was marked as a duplicate.

Note: See TracTickets for help on using tickets.