WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#49494 closed defect (bug) (fixed)

Ignore Twenty Nineteen's node_modules directory in "jshint:themes" task

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Previously: #46706.

Twenty Nineteen uses npm to run various build tasks: node-sass, rtlcss, etc.

Once you run npm install in the theme's directory, the grunt jshint:themes task fails due to attempting to check files in twentynineteen/node_modules. This directory should be excluded from the task.

Change History (2)

#1 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47348:

Built/Test Tools: Ignore the node_modules folder in Twenty Nineteen when running grunt jshint:themes.

Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.

#2 @SergeyBiryukov
6 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.