WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#49521 closed enhancement (fixed)

Append lostpassword_errors filter to `retrieve_password()`

Reported by: wpdo5ea's profile wpdo5ea Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.4
Component: Login and Registration Keywords: has-patch has-dev-note
Focuses: Cc:

Description

Currently comparing to login and register process, lost password submission didn't have any error filter, which makes it hard to append more errors.

Similar to the part in register_new_user() function, added the filter lostpassword_errors to errors encountered.

Attachments (2)

lostpassword_errors_filter.diff​ (667 bytes) - added by wpdo5ea 3 years ago.
49521.2.patch​ (681 bytes) - added by dilipbheda 3 years ago.
I did change in filter comment area. I am not sure it is better to understand or not for our user.

Download all attachments as: .zip

Change History (8)

@wpdo5ea
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.5
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

@dilipbheda
3 years ago

I did change in filter comment area. I am not sure it is better to understand or not for our user.

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
3 years ago

#3 @davidbaumwald
3 years ago

  • Keywords needs-dev-note added

Since this adds a new filter, marking for a dev-note call-out on the Misc Dev Note.

#4 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48084:

Login and Registration: Introduce lostpassword_errors filter in retrieve_password() for errors encountered on a password reset request.

This complements the registration_errors filter in register_new_user().

Props wpdo5ea, dilipbheda.
Fixes #49521.

#5 @SergeyBiryukov
3 years ago

In 48085:

Docs: Add missing $user_data parameter name to lostpassword_post and lostpassword_errors filter DocBlocks.

Follow-up to [48084].

See #49521, #49572.

#6 @desrosj
3 years ago

  • Keywords has-dev-note added; needs-dev-note removed

This received a call out in the Miscellaneous Developer Changes in 5.5 dev note: ​https://make.wordpress.org/core/2020/07/29/miscellaneous-developer-focused-changes-in-wordpress-5-5/.

Note: See TracTickets for help on using tickets.