Twenty Twenty: searchform.php error

[fahimmurshed]

twentytwenty/searchform.php

**18	ERROR	Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$unique_id".

// phpcs:ignore WPThemeReview.CoreFunctionality.PrefixAllGlobals.NonPrefixedVariableFound
20	ERROR	Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$aria_label".

phpcs:ignore WPThemeReview.CoreFunctionality.PrefixAllGlobals.NonPrefixedVariableFound

[fahimmurshed]

Patch

[fahimmurshed]

Patch. Please ignore another patch file.

[fahimmurshed]

Please edit to add the version 5.3.2

Thanks.

[ianbelanger]

Updated patch with all variables updated

[ianbelanger]

Thanks for you patch @fahimmurshed, I tested it and found that there were 2 undefined variable notices, so I uploaded a new patch with all variables updated. Please test it to confirm that my patch works for you. Thanks

[fahimmurshed]

Perfect!

I have removed the hyphen $twentytwenty_unique_id = twentytwenty_unique_id( 'search-form' );:18

Removed from this word search-form

Do you think that's the right decision?

[fahimmurshed]

Updated patch with all variables updated

[ianbelanger]

I think that the hyphen needs to stay, so that the ID is something like search-form-1 vs search-form1. That is more in line with how things are done in WP. Thanks for submitting you patches.

[fahimmurshed]

I'll re-upload the correct patch, Ian.

Thanks so much for pointing me. You know I am learning day by day :D

[fahimmurshed]

Updated final patch

[ianbelanger]

In 47393:

Bundled Themes: Twenty Twenty searchform.php error.

Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.

[ianbelanger]

Reopening for backport.

[audrasjb]

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.