#49534 closed enhancement (fixed)
Twenty Twenty: Remove Non-printable characters from starter-content.php file
Reported by: | fahimmurshed | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | low |
Severity: | normal | Version: | 5.3 |
Component: | Bundled Theme | Keywords: | needs-patch |
Focuses: | Cc: |
Description
I have check this theme with "Theme Check" plugin and it's show this:
INFO: Non-printable characters were found in the starter-content.php file. You may want to check this file for errors.
/inc/starter-content.php:129
'<h2 class="has-accent-color has-text-align-center">' . __( '”Cyborgs, as the philosopher Donna Haraway established, are not reverent. They do not remember the cosmos.”', 'twentytwenty' ) . '</h2>',
Removed the ” and ”
Attachments (1)
Change History (9)
#1
@
5 years ago
- Summary changed from Remove Non-printable characters from starter-content.php file to Twenty Twenty: Remove Non-printable characters from starter-content.php file
#2
@
5 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Awaiting Review to Future Release
- Priority changed from normal to low
- Type changed from defect (bug) to enhancement
- Version changed from trunk to 5.3
Instead of removing the quotes they should be replaced with HTML entities.
#4
@
5 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 47388:
#6
follow-up:
↓ 7
@
5 years ago
@SergeyBiryukov I'd prefer if you could give others a chance to create a patch first. There was nothing important here that requires an immediate commit for the 5.4 branch.
#7
in reply to:
↑ 6
@
5 years ago
Replying to ocean90:
I'd prefer if you could give others a chance to create a patch first. There was nothing important here that requires an immediate commit for the 5.4 branch.
This is one of the author's 12 tickets, most of which were closed for various reasons without a commit.
Getting people to contribute to core is hard as is, I'm too familiar with contributors (new and old) giving up if their efforts are not recognized.
This seemed like a good opportunity to provide some encouragement.
Patch