Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 8 months ago

#49534 closed enhancement (fixed)

Twenty Twenty: Remove Non-printable characters from starter-content.php file

Reported by: fahimmurshed's profile fahimmurshed Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: low
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

I have check this theme with "Theme Check" plugin and it's show this:

INFO: Non-printable characters were found in the starter-content.php file. You may want to check this file for errors.

/inc/starter-content.php:129

'<h2 class="has-accent-color has-text-align-center">' . __( '”Cyborgs, as the philosopher Donna Haraway established, are not reverent. They do not remember the cosmos.”', 'twentytwenty' ) . '</h2>',

Removed the ” and ”

Attachments (1)

49534.diff (2.2 KB) - added by fahimmurshed 5 years ago.
Patch

Download all attachments as: .zip

Change History (9)

@fahimmurshed
5 years ago

Patch

#1 @SergeyBiryukov
5 years ago

  • Summary changed from Remove Non-printable characters from starter-content.php file to Twenty Twenty: Remove Non-printable characters from starter-content.php file

#2 @ocean90
5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Type changed from defect (bug) to enhancement
  • Version changed from trunk to 5.3

Instead of removing the quotes they should be replaced with HTML entities.

#3 @fahimmurshed
5 years ago

Thanks, Dominik

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47388:

Twenty Twenty: Replace quotation marks in starter content with HTML entities.

Props fahimmurshed.
Fixes #49534.

#5 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.4

#6 follow-up: @ocean90
5 years ago

@SergeyBiryukov I'd prefer if you could give others a chance to create a patch first. There was nothing important here that requires an immediate commit for the 5.4 branch.

#7 in reply to: ↑ 6 @SergeyBiryukov
5 years ago

Replying to ocean90:

I'd prefer if you could give others a chance to create a patch first. There was nothing important here that requires an immediate commit for the 5.4 branch.

This is one of the author's 12 tickets, most of which were closed for various reasons without a commit.

Getting people to contribute to core is hard as is, I'm too familiar with contributors (new and old) giving up if their efforts are not recognized.

This seemed like a good opportunity to provide some encouragement.

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#8 @fahimmurshed
5 years ago

Love your appreciations @SergeyBiryukov. Thanks so much.
To be honest, It's encouraging me to contribute here more and more.
I just love this community :)

Note: See TracTickets for help on using tickets.