WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#49546 closed defect (bug) (fixed)

Twenty Thirteen: Update calendar widget styles for 5.4 markup

Reported by: sabernhardt Owned by: ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: css Cc:

Description

Since the previous month and next month links are no longer inside table cells in version 5.4, display:block stretches each of those links the full width of the calendar container.

Though I like how the month links are larger and further away from the calendar date links, the change would be quite unexpected for other people.

(markup was changed for ticket:39763)

Attachments (6)

2013-side-comparison.jpg (74.6 KB) - added by sabernhardt 3 months ago.
comparing side widget in 5.3 and 5.4
2013-footer-comparison.jpg (67.1 KB) - added by sabernhardt 3 months ago.
comparing footer widget in 5.3 and 5.4 (at narrow width so they are aligned in one column instead of using masonry)
49546.patch (599 bytes) - added by sabernhardt 3 months ago.
Using display:table to nearly match the former styles
49546.1.patch (433 bytes) - added by sabernhardt 3 months ago.
Using display:inline-block for the new span elements
2013-side-patches.jpg (117.8 KB) - added by sabernhardt 3 months ago.
comparing patches for side widget next to 5.3 styles
2013-footer-patches.jpg (108.6 KB) - added by sabernhardt 3 months ago.
comparing patches for footer widget (again, in one column) next to 5.3 styles

Download all attachments as: .zip

Change History (14)

@sabernhardt
3 months ago

comparing side widget in 5.3 and 5.4

@sabernhardt
3 months ago

comparing footer widget in 5.3 and 5.4 (at narrow width so they are aligned in one column instead of using masonry)

@sabernhardt
3 months ago

Using display:table to nearly match the former styles

@sabernhardt
3 months ago

Using display:inline-block for the new span elements

#1 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.4

@sabernhardt
3 months ago

comparing patches for side widget next to 5.3 styles

@sabernhardt
3 months ago

comparing patches for footer widget (again, in one column) next to 5.3 styles

#2 @sabernhardt
3 months ago

Option 1: 49546.patch

  • Uses display:table and display:table-cell to nearly match the former styles (the .pad in between the links is slightly narrower)
  • Reinstates the line-height of 2 for the navigation links
  • Moves the table's bottom margin to the nav element

Option 2: 49546.1.patch

  • Simply adds display:inline-block to the new span elements (it may be preferable to add that to the .wp-calendar-nav span a elements instead)

This ticket was mentioned in Slack in #core-themes by sabernhardt. View the logs.


3 months ago

#4 @ianbelanger
3 months ago

  • Keywords commit added
  • Owner set to ianbelanger
  • Status changed from new to reviewing
  • Version trunk deleted

Reviewing for commit.

#5 @ianbelanger
3 months ago

Patch looks good @sabernhardt nice find! I'm going to commit your first patch as it more aligns with how the calendar looked before 5.4.

#6 @ianbelanger
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47392:

Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup.

Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.

#7 @ianbelanger
3 months ago

  • Keywords fixed-major added; commit removed
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#8 @ianbelanger
3 months ago

  • Keywords fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Doesn't need backport since the issue appeared in 5.4.

Note: See TracTickets for help on using tickets.