Opened 7 years ago
Closed 7 years ago
#49546 closed defect (bug) (fixed)
Twenty Thirteen: Update calendar widget styles for 5.4 markup
| Reported by: | sabernhardt | Owned by: | ianbelanger |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.4 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch has-screenshots |
| Cc: | Focuses: | css |
Description
Since the previous month and next month links are no longer inside table cells in version 5.4, display:block stretches each of those links the full width of the calendar container.
Though I like how the month links are larger and further away from the calendar date links, the change would be quite unexpected for other people.
(markup was changed for ticket:39763)
Attachments (6)
Change History (14)
@
7 years ago
comparing footer widget in 5.3 and 5.4 (at narrow width so they are aligned in one column instead of using masonry)
#2
@
7 years ago
Option 1: 49546.patch
- Uses
display:tableanddisplay:table-cellto nearly match the former styles (the .pad in between the links is slightly narrower) - Reinstates the
line-heightof 2 for the navigation links - Moves the table's bottom margin to the
navelement
Option 2: 49546.1.patch
- Simply adds
display:inline-blockto the newspanelements (it may be preferable to add that to the.wp-calendar-nav span aelements instead)
This ticket was mentioned in Slack in #core-themes by sabernhardt. View the logs.
7 years ago
#4
@
7 years ago
- Keywords commit added
- Owner set to
- Status new → reviewing
- Version trunk
Reviewing for commit.
#5
@
7 years ago
Patch looks good @sabernhardt nice find! I'm going to commit your first patch as it more aligns with how the calendar looked before 5.4.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
comparing side widget in 5.3 and 5.4