WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#49570 closed defect (bug) (fixed)

Privacy Policy Guide: Adjust white space under TOC list in mobile

Reported by: birgire Owned by: garrett-eclipse
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch commit
Focuses: ui, css Cc:

Description

The Privacy Policy Guide TOC was introduced in #43980

It seems we could increase e.g. the bottom padding of

.privacy-text-box-toc ol

in

wp-admin/privacy-policy-guide.php

to have the white space more uniform and similar to the desktop layout of the TOC.

See screenshots below.

Attachments (4)

privacy-guide-toc-mobile.png (16.2 KB) - added by birgire 7 months ago.
privacy-guide-toc-desktop.png (31.0 KB) - added by birgire 7 months ago.
#49570.diff (1.1 KB) - added by jagirbahesh 7 months ago.
Patch file for resolve the issue
#49570.2.diff (1.1 KB) - added by jagirbahesh 7 months ago.
Patch file for resolve the issue

Download all attachments as: .zip

Change History (11)

#1 @garrett-eclipse
7 months ago

  • Milestone changed from Awaiting Review to 5.5

Good catch @birgire marking for 5.5 but leaving unpatched as this as you marked is would make a good-first-bug

#2 @jagirbahesh
7 months ago

  • Keywords has-patch added; needs-patch removed

@birgire

As per the guideline, I have added CSS to fix the mobile issue.
I have also created a patch for the issue but can you please guide me how can I upload my patch file.

#3 @birgire
7 months ago

@jagirbahesh welcome to core trac.

Here are some guidelines that hopefully help:

https://make.wordpress.org/core/handbook/contribute/fixing-bugs/
https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/

You can use e.g. git or svn.

#4 @jagirbahesh
7 months ago

@birgire

Thanks for the information.
Got it but by mistake, I have added same patch file for 2 times can you please second one is removed?

Last edited 7 months ago by jagirbahesh (previous) (diff)

@jagirbahesh
7 months ago

Patch file for resolve the issue

@jagirbahesh
7 months ago

Patch file for resolve the issue

#5 @jagirbahesh
6 months ago

  • Keywords has-unit-tests added

@birgire

I have a unit test this patch file.
Here I have share screen-shot for your reference
screen-shot: https://prntscr.com/rhk1qy

#6 @garrett-eclipse
6 months ago

  • Keywords commit added; good-first-bug has-unit-tests removed
  • Owner set to garrett-eclipse
  • Status changed from new to accepted

Thanks @jagirbahesh this works nicely for me moving it forward.

#7 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47473:

Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.

Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.

Note: See TracTickets for help on using tickets.