Opened 5 years ago
Closed 5 years ago
#49570 closed defect (bug) (fixed)
Privacy Policy Guide: Adjust white space under TOC list in mobile
Reported by: | birgire | Owned by: | garrett-eclipse |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 4.9.6 |
Component: | Privacy | Keywords: | has-screenshots has-patch commit |
Focuses: | ui, css | Cc: |
Description
The Privacy Policy Guide TOC was introduced in #43980
It seems we could increase e.g. the bottom padding of
.privacy-text-box-toc ol
in
wp-admin/privacy-policy-guide.php
to have the white space more uniform and similar to the desktop layout of the TOC.
See screenshots below.
Attachments (4)
Change History (11)
#2
@
5 years ago
- Keywords has-patch added; needs-patch removed
@birgire
As per the guideline, I have added CSS to fix the mobile issue.
I have also created a patch for the issue but can you please guide me how can I upload my patch file.
#3
@
5 years ago
@jagirbahesh welcome to core trac.
Here are some guidelines that hopefully help:
https://make.wordpress.org/core/handbook/contribute/fixing-bugs/
https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
You can use e.g. git or svn.
#4
@
5 years ago
@birgire
Thanks for the information.
Got it but by mistake, I have added same patch file for 2 times can you please second one is removed?
#5
@
5 years ago
- Keywords has-unit-tests added
@birgire
I have a unit test this patch file.
Here I have share screen-shot for your reference
screen-shot: https://prntscr.com/rhk1qy
Good catch @birgire marking for 5.5 but leaving unpatched as this as you marked is would make a
good-first-bug