Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#49574 closed defect (bug) (fixed)

Editor: Update WordPress packages to make editor full-screen by default.

Reported by: jorgefilipecosta's profile jorgefilipecosta Owned by: jorgefilipecosta's profile jorgefilipecosta
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Editor Keywords: has-patch commit has-dev-note needs-post-mortem
Focuses: Cc:

Description

The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4

This update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Attachments (1)

49574.diff (22.4 KB) - added by jorgefilipecosta 4 years ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in PR #177 on WordPress/wordpress-develop by jorgefilipecosta.


4 years ago
#1

The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Ticket: https://core.trac.wordpress.org/ticket/49574

#2 @youknowriad
4 years ago

The diff looks good to me.

#3 @mcsf
4 years ago

  • Keywords commit added

Looks good to me too.

#4 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor

#5 @jorgefilipecosta
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47421:

Editor: Update WordPress packages to make editor full-screen by default.

The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.

#6 @afercia
4 years ago

  • Keywords needs-dev-note needs-post-mortem added

#7 @afercia
4 years ago

If this change is going to stay in core it definitely needs a dev note.

It is worth reminding that any plugin that relies or uses the admin toolbar will be affected by this change. Plugin authors need to be informed. I would say timely informed.

#8 @afercia
4 years ago

  • Keywords has-dev-note added; needs-dev-note removed

Sorry, I see there is a dev note published:
https://make.wordpress.org/core/2020/03/03/fullscreen-mode-enabled-by-default-in-the-editor/

This ticket missed the has-dev-note keyword though.

Last edited 4 years ago by afercia (previous) (diff)
Note: See TracTickets for help on using tickets.