WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 7 days ago

#49587 new defect (bug)

Add error handling for the media manager Ajax response

Reported by: johnbillion Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: needs-patch needs-design needs-screenshots
Focuses: javascript, administration Cc:

Description

When the media manager modal performs an Ajax request to query attachments, if the Ajax call responds with an error then the user is presented with an eternal loading spinner and no indication there has been a problem.

I think there are two places which need a fail() handler for the Ajax promise:

  • wp.media.model.Attachments.more()
  • wp.media.model.Query.more()

I haven't done any testing yet though to confirm this.

Needs a decision around how best to present an error to a user. Probably needs UI work; maybe one of the UI pieces such as the upload failure message can be reused.

Change History (4)

#1 @joemcgill
4 months ago

  • Milestone changed from Awaiting Review to 5.5

Thanks for the report @johnbillion, let's add this to 5.5 to confirm and get some design feedback on the best user experience for this.

#2 @johnbillion
3 months ago

  • Keywords needs-design added

#3 @johnbillion
3 months ago

  • Keywords needs-ux removed

#4 @estelaris
7 days ago

  • Keywords needs-screenshots added

This ticket was discussed in Design triage, we would like to see the error in a screenshot and see the "upload failure message" that could be used to solve the UI display.

Note: See TracTickets for help on using tickets.