Privacy and Ergonomics

[arena]

Export Personal Data admin page and Erase Personal Data are very very similar which can lead to some manipulation errors for short-sighted and disabled people.

The following proposition aims to fix this issue

[arena]

Export Personal Data

[arena]

Export Personal Data (screen options)

[arena]

Erase Personal Data

[arena]

Erase Personal Data (screen options)

[arena]

Erase Personal Data (new screen options and background color)

[carike]

Am I correct in saying that the only change proposed is to allow the user to change the background colour?

[carike]

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

This suggestion would be more appropriate for the Accessibility team.
(That way Plugins / Users screens, etc. could also have different background colours.)

[azaozz]

Replying to carike:

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

Yep, alternate background color(s) should be implemented "globally" for wp-admin.

This suggestion would be more appropriate for the Accessibility team.

Don't think Accessibility (and the accessibility team) has anything to do with having alternate colors, alternate background colors, alternate border colors, etc. etc. They are implemented as "admin color themes" on the user profile screen and generally fall under "UI/design".

[carike]

Thanks @azaozz :)

I only suggested Accessibility because the reason given for the proposed change was to increase contrast / help users distinguish between pages, specifically to help people who are near-sighted.
UI/Design should be best though. :sendscoffee:

[SergeyBiryukov]

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen and avoid an accidental erasure.

This might be an idea worth considering, but it would need to be done consistently across the admin, see #36882.

Tangentially related: #11304, #27370, #28235, #37016, #39712.

[arena]

@SergeyBiryukov 

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen

yes this is exactly the point.

So, you believe "trash" admin pages should also be optionally differentiated ?
That is a good point. 100% with you on this

[arena]

Profile Admin Screen with "deletion color"

[arena]

automn

[arena]

rose

[arena]

sky

[arena]

done !

would be nice !

[joedolson]

The accessibility team reviewed this today, and opened a related ticket - #49714 - to address this issue on a broader scale.

The color-only nature of this patch is of concern to us, although it's not directly an accessibility violation, given that the text on the page does indicate the destructive nature of the page - however, using a different color background selectively in a few contexts could be confusing, and could introduce unexpected contrast issues. We'd like to explore alternate solutions.

[SergeyBiryukov]

I think only specific elements here should be highlighted as destructive, not the whole screen:

• "Erase Personal Data" link in the Next Steps column.
• "Force Erase Personal Data" row action.

Marking them with a red color would be consistent with other UI elements in the admin, e.g. various "Delete", "Spam", or "Trash" links. Adding a confirmation modal if it doesn't exist already would also be valuable.

[sabernhardt]

using red text for destructive action buttons

[sabernhardt]

With 49603.1.patch​, the buttons for "Erase Personal Data" and "Force Erase Personal Data" will be in red text, as well as the "Retry" buttons that show after failed attempts.

If someone else would like to add an are-you-sure confirmation message, feel free to do that.

[audrasjb]

I tested 49603.1.patch and it works fine on my side.
Marking this for commit.

I'm not sure an are-you-sure alert is really needed as soon as the destructive action is clearly mentioned on the button.

[SergeyBiryukov]

In 51891:

Accessibility: Privacy: Use red color for action buttons on the Erase Personal Data screen:

• "Erase Personal Data" button in the Next Steps column.
• "Force Erase Personal Data" row action.

This highlights the destructive nature of those buttons to avoid an accidental erasure, and is consistent with other similar UI elements in the admin, e.g. various "Delete", "Spam", or "Trash" buttons.

Props arena, sabernhardt, carike, azaozz, joedolson, audrasjb, SergeyBiryukov.
Fixes #49603.