WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 8 days ago

#49603 reopened feature request

Privacy and Ergonomics

Reported by: arena Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch needs-testing has-screenshots
Focuses: ui, accessibility Cc:

Description

Export Personal Data admin page and Erase Personal Data are very very similar which can lead to some manipulation errors for short-sighted and disabled people.

The following proposition aims to fix this issue

Attachments (10)

screenshot1.PNG (85.6 KB) - added by arena 4 weeks ago.
Export Personal Data
screenshot2.PNG (72.4 KB) - added by arena 4 weeks ago.
Export Personal Data (screen options)
screenshot3.PNG (28.9 KB) - added by arena 4 weeks ago.
Erase Personal Data
screenshot4.PNG (29.9 KB) - added by arena 4 weeks ago.
Erase Personal Data (screen options)
screentshotA.png (77.3 KB) - added by arena 4 weeks ago.
Erase Personal Data (new screen options and background color)
Screenshot 1.PNG (38.9 KB) - added by arena 2 weeks ago.
Profile Admin Screen with "deletion color"
automn.png (127.1 KB) - added by arena 2 weeks ago.
automn
rose.png (127.7 KB) - added by arena 2 weeks ago.
rose
sky.png (126.7 KB) - added by arena 2 weeks ago.
sky
#49603.patch (13.2 KB) - added by arena 2 weeks ago.

Download all attachments as: .zip

Change History (21)

@arena
4 weeks ago

Export Personal Data

@arena
4 weeks ago

Export Personal Data (screen options)

@arena
4 weeks ago

Erase Personal Data

@arena
4 weeks ago

Erase Personal Data (screen options)

@arena
4 weeks ago

Erase Personal Data (new screen options and background color)

#1 @carike
4 weeks ago

Am I correct in saying that the only change proposed is to allow the user to change the background colour?

#2 follow-up: @carike
4 weeks ago

  • Resolution set to invalid
  • Status changed from new to closed

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

This suggestion would be more appropriate for the Accessibility team.
(That way Plugins / Users screens, etc. could also have different background colours.)

#3 in reply to: ↑ 2 @azaozz
4 weeks ago

Replying to carike:

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

Yep, alternate background color(s) should be implemented "globally" for wp-admin.

This suggestion would be more appropriate for the Accessibility team.

Don't think Accessibility (and the accessibility team) has anything to do with having alternate colors, alternate background colors, alternate border colors, etc. etc. They are implemented as "admin color themes" on the user profile screen and generally fall under "UI/design".

#4 @carike
4 weeks ago

Thanks @azaozz :)

I only suggested Accessibility because the reason given for the proposed change was to increase contrast / help users distinguish between pages, specifically to help people who are near-sighted.
UI/Design should be best though. :sendscoffee:

#5 @SergeyBiryukov
4 weeks ago

  • Component changed from General to Administration
  • Focuses ui added

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen and avoid an accidental erasure.

This might be an idea worth considering, but it would need to be done consistently across the admin, see #36882.

Tangentially related: #11304, #27370, #28235, #37016, #39712.

#6 @arena
2 weeks ago

@SergeyBiryukov 

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen

yes this is exactly the point.

So, you believe "trash" admin pages should also be optionally differentiated ?
That is a good point. 100% with you on this

@arena
2 weeks ago

Profile Admin Screen with "deletion color"

@arena
2 weeks ago

automn

@arena
2 weeks ago

rose

@arena
2 weeks ago

sky

@arena
2 weeks ago

#7 @arena
2 weeks ago

  • Focuses accessibility added
  • Keywords has-patch needs-testing needs-privacy-review has-screenshots added
  • Resolution invalid deleted
  • Status changed from closed to reopened

done !

would be nice !

#8 @Otto42
12 days ago

  • Focuses privacy removed
  • Keywords needs-privacy-review removed

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 days ago

#10 @joedolson
9 days ago

The accessibility team reviewed this today, and opened a related ticket - #49714 - to address this issue on a broader scale.

The color-only nature of this patch is of concern to us, although it's not directly an accessibility violation, given that the text on the page does indicate the destructive nature of the page - however, using a different color background selectively in a few contexts could be confusing, and could introduce unexpected contrast issues. We'd like to explore alternate solutions.

#11 @SergeyBiryukov
8 days ago

I think only specific elements here should be highlighted as destructive, not the whole screen:

  • "Erase Personal Data" link in the Next Steps column.
  • "Force Erase Personal Data" row action.

Marking them with a red color would be consistent with other UI elements in the admin, e.g. various "Delete", "Spam", or "Trash" links. Adding a confirmation modal if it doesn't exist already would also be valuable.

Note: See TracTickets for help on using tickets.