Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#49603 closed enhancement (fixed)

Privacy and Ergonomics

Reported by: arena's profile arena Owned by: sabernhardt's profile sabernhardt
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-patch has-screenshots commit
Focuses: ui, accessibility, administration Cc:

Description

Export Personal Data admin page and Erase Personal Data are very very similar which can lead to some manipulation errors for short-sighted and disabled people.

The following proposition aims to fix this issue

Attachments (12)

screenshot1.PNG (85.6 KB) - added by arena 4 years ago.
Export Personal Data
screenshot2.PNG (72.4 KB) - added by arena 4 years ago.
Export Personal Data (screen options)
screenshot3.PNG (28.9 KB) - added by arena 4 years ago.
Erase Personal Data
screenshot4.PNG (29.9 KB) - added by arena 4 years ago.
Erase Personal Data (screen options)
screentshotA.png (77.3 KB) - added by arena 4 years ago.
Erase Personal Data (new screen options and background color)
Screenshot 1.PNG (38.9 KB) - added by arena 4 years ago.
Profile Admin Screen with "deletion color"
automn.png (127.1 KB) - added by arena 4 years ago.
automn
rose.png (127.7 KB) - added by arena 4 years ago.
rose
sky.png (126.7 KB) - added by arena 4 years ago.
sky
#49603.patch (13.2 KB) - added by arena 4 years ago.
49603.1.patch (775 bytes) - added by sabernhardt 3 years ago.
using red text for destructive action buttons
erase-personal-data-destructive-buttons.png (18.7 KB) - added by sabernhardt 3 years ago.

Download all attachments as: .zip

Change History (29)

@arena
4 years ago

Export Personal Data

@arena
4 years ago

Export Personal Data (screen options)

@arena
4 years ago

Erase Personal Data

@arena
4 years ago

Erase Personal Data (screen options)

@arena
4 years ago

Erase Personal Data (new screen options and background color)

#1 @carike
4 years ago

Am I correct in saying that the only change proposed is to allow the user to change the background colour?

#2 follow-up: @carike
4 years ago

  • Resolution set to invalid
  • Status changed from new to closed

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

This suggestion would be more appropriate for the Accessibility team.
(That way Plugins / Users screens, etc. could also have different background colours.)

#3 in reply to: ↑ 2 @azaozz
4 years ago

Replying to carike:

The privacy tools make use of the same stylesheet as the rest of /wp-admin/

Yep, alternate background color(s) should be implemented "globally" for wp-admin.

This suggestion would be more appropriate for the Accessibility team.

Don't think Accessibility (and the accessibility team) has anything to do with having alternate colors, alternate background colors, alternate border colors, etc. etc. They are implemented as "admin color themes" on the user profile screen and generally fall under "UI/design".

#4 @carike
4 years ago

Thanks @azaozz :)

I only suggested Accessibility because the reason given for the proposed change was to increase contrast / help users distinguish between pages, specifically to help people who are near-sighted.
UI/Design should be best though. :sendscoffee:

#5 @SergeyBiryukov
4 years ago

  • Component changed from General to Administration
  • Focuses ui added

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen and avoid an accidental erasure.

This might be an idea worth considering, but it would need to be done consistently across the admin, see #36882.

Tangentially related: #11304, #27370, #28235, #37016, #39712.

#6 @arena
4 years ago

@SergeyBiryukov 

It looks like the background color is proposed here as a way to highlight the destructive nature of the Erase Personal Data screen

yes this is exactly the point.

So, you believe "trash" admin pages should also be optionally differentiated ?
That is a good point. 100% with you on this

@arena
4 years ago

Profile Admin Screen with "deletion color"

@arena
4 years ago

automn

@arena
4 years ago

rose

@arena
4 years ago

sky

@arena
4 years ago

#7 @arena
4 years ago

  • Focuses accessibility added
  • Keywords has-patch needs-testing needs-privacy-review has-screenshots added
  • Resolution invalid deleted
  • Status changed from closed to reopened

done !

would be nice !

#8 @Otto42
4 years ago

  • Focuses privacy removed
  • Keywords needs-privacy-review removed

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#10 @joedolson
4 years ago

The accessibility team reviewed this today, and opened a related ticket - #49714 - to address this issue on a broader scale.

The color-only nature of this patch is of concern to us, although it's not directly an accessibility violation, given that the text on the page does indicate the destructive nature of the page - however, using a different color background selectively in a few contexts could be confusing, and could introduce unexpected contrast issues. We'd like to explore alternate solutions.

#11 @SergeyBiryukov
4 years ago

I think only specific elements here should be highlighted as destructive, not the whole screen:

  • "Erase Personal Data" link in the Next Steps column.
  • "Force Erase Personal Data" row action.

Marking them with a red color would be consistent with other UI elements in the admin, e.g. various "Delete", "Spam", or "Trash" links. Adding a confirmation modal if it doesn't exist already would also be valuable.

This ticket was mentioned in Slack in #accessibility by alexstine. View the logs.


3 years ago

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


3 years ago

#14 @sabernhardt
3 years ago

  • Component changed from Administration to Privacy
  • Focuses administration added
  • Milestone changed from Awaiting Review to 5.9
  • Owner set to sabernhardt
  • Status changed from reopened to accepted
  • Type changed from feature request to enhancement

@sabernhardt
3 years ago

using red text for destructive action buttons

#15 @sabernhardt
3 years ago

With 49603.1.patch, the buttons for "Erase Personal Data" and "Force Erase Personal Data" will be in red text, as well as the "Retry" buttons that show after failed attempts.

If someone else would like to add an are-you-sure confirmation message, feel free to do that.

#16 @audrasjb
3 years ago

  • Keywords commit added; needs-testing removed

I tested 49603.1.patch and it works fine on my side.
Marking this for commit.

I'm not sure an are-you-sure alert is really needed as soon as the destructive action is clearly mentioned on the button.

#17 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51891:

Accessibility: Privacy: Use red color for action buttons on the Erase Personal Data screen:

  • "Erase Personal Data" button in the Next Steps column.
  • "Force Erase Personal Data" row action.

This highlights the destructive nature of those buttons to avoid an accidental erasure, and is consistent with other similar UI elements in the admin, e.g. various "Delete", "Spam", or "Trash" buttons.

Props arena, sabernhardt, carike, azaozz, joedolson, audrasjb, SergeyBiryukov.
Fixes #49603.

Note: See TracTickets for help on using tickets.