WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#49619 closed defect (bug) (fixed)

Use <hr /> instead of margin on Freedoms page.

Reported by: chetan200891 Owned by: SergeyBiryukov
Priority: normal Milestone: 5.4
Component: Help/About Version: 5.4
Severity: normal Keywords: has-patch has-screenshots commit fixed-major dev-reviewed
Cc: Focuses: ui

Description

On freedoms.php there is margin-bottom used instead of <hr />. On other page <hr /> used to separate sections. So on freedoms.php it should be <hr /> instead of margin-bottom.

Attachments (2)

49619.diff​ (776 bytes ) - added by chetan200891 7 years ago.
Created patch.
49619.png​ (19.1 KB ) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (11)

@chetan200891
7 years ago

Created patch.

#1 @chetan200891
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

  • Component General → Help/About
  • Milestone Awaiting Review → 5.4

@SergeyBiryukov
7 years ago

#3 @SergeyBiryukov
7 years ago

  • Keywords has-screenshots commit added

Thanks for the patch! Just confirming 49619.diff​ indeed fixes the inconsistent vertical whitespace. Looks good to me.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 47443:

Help/About: Use consistent vertical whitespace between sections on Freedoms page.

Props chetan200891.
Fixes #49619.

#5 @SergeyBiryukov
7 years ago

  • Keywords fixed-major dev-feedback added
  • Resolution fixed
  • Status closed → reopened

Reopening for backporting to the 5.4 branch after a second committer's review.

While not strictly a regression in 5.4, this is related to the 5.3 About page design overhaul in #47708, so it's technically a regression in that release.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#6 @kirasong
6 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#7 @kirasong
6 years ago

  • Keywords dev-feedback added; dev-reviewed removed

Ah, apologies, the above was meant for a different ticket. Reverting that change in tags.

#8 @whyisjake
6 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#9 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status reopened → closed

In 47464:

Help/About: Use consistent vertical whitespace between sections on Freedoms page.

Props chetan200891.
Reviewed by whyisjake, SergeyBiryukov.
Merges [47443] to the 5.4 branch.
Fixes #49619.

Note: See TracTickets for help on using tickets.