Opened 5 years ago
Closed 5 years ago
#49619 closed defect (bug) (fixed)
Use <hr /> instead of margin on Freedoms page.
Reported by: | chetan200891 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 5.4 |
Component: | Help/About | Keywords: | has-patch has-screenshots commit fixed-major dev-reviewed |
Focuses: | ui | Cc: |
Description
On freedoms.php there is margin-bottom used instead of <hr />. On other page <hr /> used to separate sections. So on freedoms.php it should be <hr /> instead of margin-bottom.
Attachments (2)
Change History (11)
#2
@
5 years ago
- Component changed from General to Help/About
- Milestone changed from Awaiting Review to 5.4
#3
@
5 years ago
- Keywords has-screenshots commit added
Thanks for the patch! Just confirming 49619.diff indeed fixes the inconsistent vertical whitespace. Looks good to me.
#4
@
5 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 47443:
#5
@
5 years ago
- Keywords fixed-major dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.4 branch after a second committer's review.
While not strictly a regression in 5.4, this is related to the 5.3 About page design overhaul in #47708, so it's technically a regression in that release.
Note: See
TracTickets for help on using
tickets.
Created patch.