WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#49619 closed defect (bug) (fixed)

Use <hr /> instead of margin on Freedoms page.

Reported by: chetan200891 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Help/About Keywords: has-patch has-screenshots commit fixed-major dev-reviewed
Focuses: ui Cc:

Description

On freedoms.php there is margin-bottom used instead of <hr />. On other page <hr /> used to separate sections. So on freedoms.php it should be <hr /> instead of margin-bottom.

Attachments (2)

49619.diff (776 bytes) - added by chetan200891 3 months ago.
Created patch.
49619.png (19.1 KB) - added by SergeyBiryukov 3 months ago.

Download all attachments as: .zip

Change History (11)

@chetan200891
3 months ago

Created patch.

#1 @chetan200891
3 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 months ago

  • Component changed from General to Help/About
  • Milestone changed from Awaiting Review to 5.4

@SergeyBiryukov
3 months ago

#3 @SergeyBiryukov
3 months ago

  • Keywords has-screenshots commit added

Thanks for the patch! Just confirming 49619.diff indeed fixes the inconsistent vertical whitespace. Looks good to me.

#4 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47443:

Help/About: Use consistent vertical whitespace between sections on Freedoms page.

Props chetan200891.
Fixes #49619.

#5 @SergeyBiryukov
3 months ago

  • Keywords fixed-major dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.4 branch after a second committer's review.

While not strictly a regression in 5.4, this is related to the 5.3 About page design overhaul in #47708, so is technically a regression in that release.

Version 1, edited 3 months ago by SergeyBiryukov (previous) (next) (diff)

#6 @mikeschroder
2 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#7 @mikeschroder
2 months ago

  • Keywords dev-feedback added; dev-reviewed removed

Ah, apologies, the above was meant for a different ticket. Reverting that change in tags.

#8 @whyisjake
2 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#9 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47464:

Help/About: Use consistent vertical whitespace between sections on Freedoms page.

Props chetan200891.
Reviewed by whyisjake, SergeyBiryukov.
Merges [47443] to the 5.4 branch.
Fixes #49619.

Note: See TracTickets for help on using tickets.