Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #49628, comment 26


Ignore:
Timestamp:
11/09/2021 08:23:53 AM (3 years ago)
Author:
Cybr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #49628, comment 26

    initial v1  
    992. We should not fix PHP's "quirks" for type juggling. PHP gives `[] == false` and `[false] == true`. Those quirks apply to everyone on every line of comparative code they write.
    1010
    11 Although this is not a new design pattern in Core, I consider them all incorrect.
     11Although the strict checks are not a new design pattern in Core, I consider them all incorrect.
    1212
    1313To repeat, I believe we should only strictly type filter return values when applicable PHP code requires a strict type and would error out without proper typing.