Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #49635, comment 5


Ignore:
Timestamp:
06/07/2020 09:18:12 PM (4 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #49635, comment 5

    initial v1  
    77The problems (as mentioned in [#comment:1 comment:1]) are:
    881. These files will be missing or will not get updated in `/src` when doing `npm run build` or `grunt build` or similar. This might trigger a PHP fatal when testing but seems pretty rare edge case.
    9 2. After the delete + ignore steps are committed, reverting to an earlier revision (where the files are still under version control) may result in SVN conflicts that could also trigger PHP fatal(s) in `/src`.
     92. After the delete + ignore steps are committed, reverting to an earlier revision (where the files are still under version control) may result in SVN conflicts that could also trigger PHP fatal(s) in `/src` if left unfixed.
    1010
    1111Both of these seem like pretty rare edge cases, so can probably just "bite the bullet" and do it? :)