WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 10 days ago

#49653 closed enhancement (fixed)

[Theme compatibilty] WP/PHP compatibility testing during theme install

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.4
Component: Site Health Keywords: has-patch dev-feedback needs-testing early needs-dev-note
Focuses: administration Cc:

Description

I think this is the last piece of the puzzle. Many thanks to @dd32 for #Meta5099 which makes this possible.

We should test and disable the ability to install themes that have specific requirements that are set in the theme's style.css file and are not supported by the users server.

Attachments (4)

screenshot_80.png (258.2 KB) - added by afragen 2 months ago.
customizer preview view
screenshot_79.png (450.1 KB) - added by afragen 2 months ago.
Add theme view
49653.diff (3.6 KB) - added by afragen 2 months ago.
49653.2.diff (7.4 KB) - added by afragen 2 months ago.
dot org

Download all attachments as: .zip

Change History (15)

@afragen
2 months ago

customizer preview view

@afragen
2 months ago

Add theme view

@afragen
2 months ago

#1 @afragen
2 months ago

  • Keywords has-patch dev-feedback needs-testing added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.5
  • Version set to trunk

I would like to thank @TimothyBlynJacobs for his insight as this patch wouldn't work without him. 🤗

#2 @afragen
2 months ago

Test with a local install at PHP 5.6 and the "Codify" theme requires PHP 7.0

@afragen
2 months ago

dot org

#3 @afragen
2 months ago

  • Keywords early added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


6 weeks ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #themereview by clorith. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


2 weeks ago

#10 @afragen
2 weeks ago

  • Keywords needs-dev-note added

#11 @SergeyBiryukov
10 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47819:

Themes: Prevent installation of themes that require a higher version of PHP or WordPress.

Props afragen.
Fixes #49653. See #48491.

Note: See TracTickets for help on using tickets.