WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#49653 closed enhancement (fixed)

[Theme compatibility] WP/PHP compatibility testing during theme install

Reported by: afragen's profile afragen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.4
Component: Site Health Keywords: has-patch dev-feedback needs-testing early has-dev-note
Focuses: administration Cc:

Description

I think this is the last piece of the puzzle. Many thanks to @dd32 for ​#Meta5099 which makes this possible.

We should test and disable the ability to install themes that have specific requirements that are set in the theme's style.css file and are not supported by the users server.

Attachments (4)

screenshot_80.png​ (258.2 KB) - added by afragen 5 years ago.
customizer preview view
screenshot_79.png​ (450.1 KB) - added by afragen 5 years ago.
Add theme view
49653.diff​ (3.6 KB) - added by afragen 5 years ago.
49653.2.diff​ (7.4 KB) - added by afragen 5 years ago.
dot org

Download all attachments as: .zip

Change History (18)

@afragen
5 years ago

customizer preview view

@afragen
5 years ago

Add theme view

@afragen
5 years ago

#1 @afragen
5 years ago

  • Keywords has-patch dev-feedback needs-testing added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.5
  • Version set to trunk

I would like to thank @TimothyBlynJacobs for his insight as this patch wouldn't work without him. 🤗

#2 @afragen
5 years ago

Test with a local install at PHP 5.6 and the "Codify" theme requires PHP 7.0

@afragen
5 years ago

dot org

#3 @afragen
5 years ago

  • Keywords early added

This ticket was mentioned in ​Slack in #core-site-health by afragen. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #core-site-health by afragen. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #themereview by clorith. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

#10 @afragen
4 years ago

  • Keywords needs-dev-note added

#11 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47819:

Themes: Prevent installation of themes that require a higher version of PHP or WordPress.

Props afragen.
Fixes #49653. See #48491.

#12 @desrosj
4 years ago

In 48071:

Site Health: Verify PHP version requirements when auto-updating themes.

Follow up of [47819].
See #49653.
Fixes #50411.

#13 @SergeyBiryukov
4 years ago

  • Summary changed from [Theme compatibilty] WP/PHP compatibility testing during theme install to [Theme compatibility] WP/PHP compatibility testing during theme install

#14 @justinahinon
4 years ago

  • Keywords has-dev-note added; needs-dev-note removed

Dev note link: ​https://make.wordpress.org/core/2020/07/30/themes-field-guide-wordpress-5-5/

Note: See TracTickets for help on using tickets.