WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#49677 closed enhancement (invalid)

"admin-preview-callback" in "custom-header" probably used to work

Reported by: RSalnikov Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.4
Component: Customize Keywords:
Focuses: ui, administration, template Cc:

Description

Trying to do any thing with "admin_header_image" i found out, that this callback doesn't work at all. I found, it works when we currently placing at one of several steps.
1) Open created page in Appearance -> Header https://github.com/WordPress/WordPress/blob/7004afe4f4bac1fd17a142051832bdf6be8e6fcf/wp-admin/includes/class-custom-image-header.php#L73
2) There is should be some steps but they are absent in the page https://github.com/WordPress/WordPress/blob/7004afe4f4bac1fd17a142051832bdf6be8e6fcf/wp-admin/includes/class-custom-image-header.php#L1031

Change History (6)

#1 follow-up: @joyously
8 months ago

What was it that "doesn't work anymore"? Did it ever work? What are you referring to?
Perhaps your question should be on the support forums instead.

#2 in reply to: ↑ 1 @RSalnikov
8 months ago

Replying to joyously:

What was it that "doesn't work anymore"? Did it ever work? What are you referring to?
Perhaps your question should be on the support forums instead.

I thought it used to work. My bad if this callback is working correctly. Would be nice if we have more examples how to use this callback, because right now i stuck and don't know where i can digging in to solve my issue...

#3 @RSalnikov
8 months ago

  • Summary changed from "admin_header_image" in "custom-header" doesn't work anymore to "admin_header_image" in "custom-header" probably used to work

#4 @RSalnikov
8 months ago

  • Summary changed from "admin_header_image" in "custom-header" probably used to work to "admin-preview-callback" in "custom-header" probably used to work

#5 @RSalnikov
8 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Ah, i confused some things. Thank for helping=)

#6 @SergeyBiryukov
8 months ago

  • Focuses accessibility docs removed
  • Milestone Awaiting Review deleted

Thanks for the follow-up!

Note: See TracTickets for help on using tickets.