Make WordPress Core

Opened 17 years ago

Closed 14 years ago

#4968 closed defect (bug) (fixed)

make_url_footnote() function not used

Reported by: markjaquith's profile markjaquith Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.3
Component: Feeds Keywords: needs-patch
Focuses: Cc:

Description

We have a make_url_footnote() function that extracts links and puts them at the bottom, Daring Fireball style. It is used in the_content_rss(), but we never call it in a way that will cause it to be used.

I suggest we drop it.

Relates to #4967 -- because if the_content_rss() is called without passing a $cut parameter, we will trigger the make_url_footnote() functionality.

Attachments (3)

4968.2.diff (1.6 KB) - added by regulatethis 16 years ago.
FWIW, this patch removes the function make_url_footnote and the 1 call to it. Seems straightforward, but could use some more testing.
4968.patch (2.2 KB) - added by hakre 15 years ago.
4968.2.patch (3.7 KB) - added by hakre 15 years ago.
no more deprecated function calls in the_content_rss() plus better docblock comments.

Download all attachments as: .zip

Change History (14)

@regulatethis
16 years ago

FWIW, this patch removes the function make_url_footnote and the 1 call to it. Seems straightforward, but could use some more testing.

#1 @Viper007Bond
15 years ago

  • Component changed from General to Feeds
  • Keywords has-patch needs-testing added
  • Milestone changed from 2.9 to Unassigned
  • Owner anonymous deleted

#2 @Denis-de-Bernardy
15 years ago

  • Milestone changed from Unassigned to Future Release

imo the patch should add the function to the deprecated list in case an odd plugin uses it.

#4 @Denis-de-Bernardy
15 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

#5 @Denis-de-Bernardy
15 years ago

  • Milestone changed from Future Release to 2.9

#6 follow-up: @hakre
15 years ago

How is a function set on the deprecated list?

#7 in reply to: ↑ 6 @Viper007Bond
15 years ago

Replying to hakre:

How is a function set on the deprecated list?

It's moved to deprecated.php and a function call is added inside of it that logs the call.

@hakre
15 years ago

#8 @hakre
15 years ago

This is patched now and moved to deprecated. The existing function call can/should stay in then? If not, I'm just doing another patch by removing the calls from source and upload it in some minutes.

@hakre
15 years ago

no more deprecated function calls in the_content_rss() plus better docblock comments.

#9 @hakre
15 years ago

Cross-Referencing another deprecated patch: #4915

#10 @Viper007Bond
15 years ago

Close, but not quite. The deprecated function should still operate as it currently does (i.e. keep all the existing code of the function), but just add in the logger function (including the third parameter) and move it to the new file. See the other functions in deprecated.php as an example.

#11 @ryan
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12203]) Deprecate make_url_footnote(). fixes #4968

Note: See TracTickets for help on using tickets.