make_url_footnote() function not used

[markjaquith]

We have a make_url_footnote() function that extracts links and puts them at the bottom, Daring Fireball style. It is used in the_content_rss(), but we never call it in a way that will cause it to be used.

I suggest we drop it.

Relates to #4967 -- because if the_content_rss() is called without passing a $cut parameter, we will trigger the make_url_footnote() functionality.

[regulatethis]

FWIW, this patch removes the function make_url_footnote and the 1 call to it. Seems straightforward, but could use some more testing.

[Denis-de-Bernardy]

imo the patch should add the function to the deprecated list in case an odd plugin uses it.

[Denis-de-Bernardy]

See also: #4967, #8706 and #3884

[hakre]

How is a function set on the deprecated list?

[Viper007Bond]

Replying to hakre:

How is a function set on the deprecated list?

It's moved to deprecated.php and a function call is added inside of it that logs the call.

[hakre]

This is patched now and moved to deprecated. The existing function call can/should stay in then? If not, I'm just doing another patch by removing the calls from source and upload it in some minutes.

[hakre]

no more deprecated function calls in the_content_rss() plus better docblock comments.

[hakre]

Cross-Referencing another deprecated patch: #4915

[Viper007Bond]

Close, but not quite. The deprecated function should still operate as it currently does (i.e. keep all the existing code of the function), but just add in the logger function (including the third parameter) and move it to the new file. See the other functions in deprecated.php as an example.

[ryan]

(In [12203]) Deprecate make_url_footnote(). fixes #4968