Cached wp_count_posts() result may not contain all statuses

[obliviousharmony]

Hello,

The wp_count_posts() function returns all of the post counts keyed by the status. This result is cached and served on subsequent calls. If a post status has no posts and has not been registered when the function is called, the cached response will contain no entry for the status. This leads to problems when iterating using get_post_stati() as not all of the post statuses will have a count.

When wp_count_posts() is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all plugins have registered their desired statuses, they won't have that default.

Related Issues:
woocommerce/woocommerce#25949

Trac ticket: https://core.trac.wordpress.org/ticket/49685

[obliviousharmony]

Could you take a look at this one too @desrosj?

[whyisjake]

In 48497:

Posts, Post Types: Ensure that all post stati are countable in wp_count_posts.

When wp_count_posts() is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all plugins have registered their desired statuses, they won't have that default.

Fixes #49685.

Props obliviousharmony, SergeyBiryukov.

Closing, merged here: https://core.trac.wordpress.org/changeset/48497