Opened 5 years ago
Closed 5 years ago
#49699 closed defect (bug) (fixed)
Twenty Nineteen: Center- and right-aligned heading accents appear broken.
Reported by: | kjellr | Owned by: | ianbelanger |
---|---|---|---|
Milestone: | 5.4.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch fixed-major |
Focuses: | css | Cc: |
Description
By default, H1 and H2 headings in Twenty Nineteen include a little accent before them:
When those headings are center- and right-aligned however, the accent stays in place:
This appears broken.
The most obvious fix would be to have those dividers move around with the text:
I'ma little partial to that one for consistency's sake, but another option would be to just remove those accents when the heading is not left aligned:
Attachments (2)
Change History (9)
#2
@
5 years ago
I like moving the accent line depending on alignment! Feels like such a distinctive style for the theme.
#3
@
5 years ago
- Focuses css added
- Milestone changed from Awaiting Review to 5.5
- Version trunk deleted
I agree with @kjellr and @melchoyce on this. I'll test the patch and if all goes well I'll get it committed and into the next release, after 5.4.
#4
@
5 years ago
- Owner set to ianbelanger
- Resolution set to fixed
- Status changed from new to closed
In 47591:
#5
@
5 years ago
- Keywords fixed-major added
- Milestone changed from 5.5 to 5.4.2
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backport.
49699.patch is a patch for that first option: moving the accent in line with the heading's alignment. (This seems like the most reasonable approach to me.)
But just in case, 49699-alt.patch is a patch for that second one: removing the accent for center and right alignments.