WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

#49699 closed defect (bug) (fixed)

Twenty Nineteen: Center- and right-aligned heading accents appear broken.

Reported by: kjellr Owned by: ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: css Cc:

Description

By default, H1 and H2 headings in Twenty Nineteen include a little accent before them:

http://cldup.com/y7fpYMLgyB.png

When those headings are center- and right-aligned however, the accent stays in place:

http://cldup.com/CcoBuLElzG.png

This appears broken.


The most obvious fix would be to have those dividers move around with the text:

http://cldup.com/xFQor-jhYK.png

I'ma little partial to that one for consistency's sake, but another option would be to just remove those accents when the heading is not left aligned:

http://cldup.com/GgdpAkGLnU.png

Attachments (2)

49699.patch (4.9 KB) - added by kjellr 6 months ago.
49699-alt.patch (3.0 KB) - added by kjellr 6 months ago.

Download all attachments as: .zip

Change History (9)

@kjellr
6 months ago

@kjellr
6 months ago

#1 @kjellr
6 months ago

49699.patch is a patch for that first option: moving the accent in line with the heading's alignment. (This seems like the most reasonable approach to me.)

But just in case, 49699-alt.patch is a patch for that second one: removing the accent for center and right alignments.

#2 @melchoyce
6 months ago

I like moving the accent line depending on alignment! Feels like such a distinctive style for the theme.

#3 @ianbelanger
6 months ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.5
  • Version trunk deleted

I agree with @kjellr and @melchoyce on this. I'll test the patch and if all goes well I'll get it committed and into the next release, after 5.4.

#4 @ianbelanger
5 months ago

  • Owner set to ianbelanger
  • Resolution set to fixed
  • Status changed from new to closed

In 47591:

Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken.

Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Props kjellr, melchoyce.
Fixes #49699.

#5 @ianbelanger
5 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#6 @ianbelanger
5 months ago

  • Summary changed from [Twenty Nineteen] Center- and right-aligned heading accents appear broken. to Twenty Nineteen: Center- and right-aligned heading accents appear broken.

#7 @whyisjake
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47806:

Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken.

Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Bringing the changes in [47591] to the 5.4 branch.

Props kjellr, melchoyce.
Fixes #49699.

Note: See TracTickets for help on using tickets.