WordPress.org

Make WordPress Core

Opened 2 weeks ago

Last modified 2 weeks ago

#49699 new defect (bug)

[Twenty Nineteen] Center- and right-aligned heading accents appear broken.

Reported by: kjellr Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

By default, H1 and H2 headings in Twenty Nineteen include a little accent before them:

http://cldup.com/y7fpYMLgyB.png

When those headings are center- and right-aligned however, the accent stays in place:

http://cldup.com/CcoBuLElzG.png

This appears broken.


The most obvious fix would be to have those dividers move around with the text:

http://cldup.com/xFQor-jhYK.png

I'ma little partial to that one for consistency's sake, but another option would be to just remove those accents when the heading is not left aligned:

http://cldup.com/GgdpAkGLnU.png

Attachments (2)

49699.patch (4.9 KB) - added by kjellr 2 weeks ago.
49699-alt.patch (3.0 KB) - added by kjellr 2 weeks ago.

Download all attachments as: .zip

Change History (5)

@kjellr
2 weeks ago

@kjellr
2 weeks ago

#1 @kjellr
2 weeks ago

49699.patch is a patch for that first option: moving the accent in line with the heading's alignment. (This seems like the most reasonable approach to me.)

But just in case, 49699-alt.patch is a patch for that second one: removing the accent for center and right alignments.

#2 @melchoyce
2 weeks ago

I like moving the accent line depending on alignment! Feels like such a distinctive style for the theme.

#3 @ianbelanger
2 weeks ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.5
  • Version trunk deleted

I agree with @kjellr and @melchoyce on this. I'll test the patch and if all goes well I'll get it committed and into the next release, after 5.4.

Note: See TracTickets for help on using tickets.