Make WordPress Core

Opened 4 years ago

Closed 3 weeks ago

#49712 closed enhancement (wontfix)

Twenty Nineteen: Add gradient background options that fit the theme color scheme

Reported by: ianbelanger's profile ianbelanger Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch close
Focuses: ui Cc:

Description (last modified by ianbelanger)

Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.

Attachments (1)

292.diff (3.7 KB) - added by lamdayap 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ianbelanger
4 years ago

  • Description modified (diff)

This ticket was mentioned in PR #292 on WordPress/wordpress-develop by lamdayap.


4 years ago
#2

  • Keywords has-patch added; needs-patch removed

I've added support for block gradient presets in the Twenty-Nineteen theme. It currently grabs the primary color and sets a linear gradient to 80% of the color.

Trac ticket: https://core.trac.wordpress.org/ticket/49712

@lamdayap
4 years ago

#3 @lamdayap
4 years ago

Hi @ianbelanger, this is one of my first handful of contributions to any sort of project and I'm very excited to try my hand at this issue! I've added a single preset to the Twenty Nineteen theme, it gets the primary color and sets a gradient to 80% opacity. I've adjusted this to be reflected in the color-patterns.php file as well. Would love to hear your thoughts. It's possible I may have missed a few places where I also need to edit the code, I'll continue to work on it. :)

#4 @karmatosed
3 weeks ago

  • Keywords close added

Thank you for your patch on this, however considering the time passed and the ideal path now being to have theme.json and block specific gradients - I am going to recommend that we close this ticket. That said, if anyone wishes to add feedback, I am for now going to add the recommended keyword of 'close' to give space for that feedback.

Thank you everyone for your collaboration so far, things have grown around how gradients and themes, so we have another approach to use now. Default themes for now are also having a focus on bug fixes not adding new features.

#5 @karmatosed
3 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to close this as it was discussed in Slack, along with other tickets around gradients. I am closing them all together after having left them open for a few days with the close keyword for feedback. Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.