#49722 closed defect (bug) (fixed)
Don't format before linting on Travis
| Reported by: | johnbillion | Owned by: | johnbillion |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.5 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-dev-note |
| Cc: | Focuses: |
Description
When the lint:php job runs on Travis, the code is formatted (with phpcbf) before it's linted. This defeats the point of linting as it means problems that can be fixed with phpcbf get missed.
Ref: https://core.trac.wordpress.org/browser/tags/5.3.2/.travis.yml?marks=124-125#L110
Introduced in [45799]. @pento Is this intentional or was it something temporary that was supposed to be removed at a later date?
Change History (4)
#4
@
6 years ago
- Keywords has-dev-note added; needs-patch removed
Referenced in the following dev note: https://make.wordpress.org/core/2020/07/14/php-related-improvements-changes-wordpress-5-5-edition/.
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
IIRC,
phpcbfwill return an error value if it makes any changes, so the subsequentphpcscommands won't be run. This was probably done for performance.The
composer formatcan probably be removed, I have no strong feelings either way on it.