WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#49724 closed enhancement (fixed)

Punctuation error in request_filesystem_credentials()

Reported by: kharisblank Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: minor Version:
Component: I18N Keywords: has-screenshots good-first-bug has-patch
Focuses: ui-copy Cc:

Description

Hello Contributors,

I am GTE for Indonesian. While working on the translation of WordPress core 5.4.x project, I found a punctuation error in this string:

https://cldup.com/5YYaKsqaHL.png

Probably it reads grammatically correct, but I found a little inconsistency compared to other strings as seen here:

https://cldup.com/sQN51nu2Vu.png

My proposal for correction would be either the first word in "Please" after comma should be lowercase or change comma to full stop.

There was an error connecting to the server, please verify the settings are correct.

or

There was an error connecting to the server. Please verify the settings are correct.

Best,
Kharis Sulistiyono

Attachments (1)

49724.diff (731 bytes) - added by mayankmajeji 2 months ago.
Punctuation Error Corrected

Download all attachments as: .zip

Change History (8)

#1 follow-up: @SergeyBiryukov
2 months ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 5.5
  • Summary changed from Puctuation error to Punctuation error in request_filesystem_credentials()

Hi there, welcome to WordPress Trac! Thanks for the report.

Just noting that the string was changed in [47156], however the sentence itself is not new and was introduced in [8540].

Either of the proposed changes look good to me. The second one would probably be more consistent with other strings.

Last edited 2 months ago by SergeyBiryukov (previous) (diff)

@mayankmajeji
2 months ago

Punctuation Error Corrected

#2 @mayankmajeji
2 months ago

  • Keywords has-patch added; needs-patch removed

#3 in reply to: ↑ 1 @mayankmajeji
2 months ago

Hi Sergey,

I've corrected the string as you have suggested. I opted the 2nd string as it matches the other standard strings pattern.

Let me know if there are any further changes.

Replying to SergeyBiryukov:

Hi there, welcome to WordPress Trac! Thanks for the report.

Just noting that the string was changed in [47156], however the sentence itself is not new and was introduced in [8540].

Either of the proposed changes look good to me. The second one would probably be more consistent with other strings.

#4 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
2 months ago

  • Component changed from I18N to Filesystem API

#6 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47530:

Filesystem API: Correct punctuation in request_filesystem_credentials() error message.

Props mayankmajeji, kharisblank.
Fixes #49724.

#7 @kharisblank
2 months ago

  • Component changed from Filesystem API to I18N

Thank you for your fix @mayankmajeji.

Have a nice day ahead :)

Note: See TracTickets for help on using tickets.