Punctuation error in request_filesystem_credentials()

[kharisblank]

Hello Contributors,

I am GTE for Indonesian. While working on the translation of WordPress core 5.4.x project, I found a punctuation error in this string:

Probably it reads grammatically correct, but I found a little inconsistency compared to other strings as seen here:

My proposal for correction would be either the first word in "Please" after comma should be lowercase or change comma to full stop.

There was an error connecting to the server, please verify the settings are correct.

or

There was an error connecting to the server. Please verify the settings are correct.

Best,
Kharis Sulistiyono

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the report.

Just noting that the string was changed in [47156], however the sentence itself is not new and was introduced in [8540].

Either of the proposed changes look good to me. The second one would probably be more consistent with other strings.

[mayankmajeji]

Punctuation Error Corrected

[mayankmajeji]

Hi Sergey,

I've corrected the string as you have suggested. I opted the 2nd string as it matches the other standard strings pattern.

Let me know if there are any further changes.

Replying to SergeyBiryukov:

Hi there, welcome to WordPress Trac! Thanks for the report.

Just noting that the string was changed in [47156], however the sentence itself is not new and was introduced in [8540].

Either of the proposed changes look good to me. The second one would probably be more consistent with other strings.

[SergeyBiryukov]

In 47530:

Filesystem API: Correct punctuation in request_filesystem_credentials() error message.

Props mayankmajeji, kharisblank.
Fixes #49724.

[kharisblank]

Thank you for your fix @mayankmajeji.

Have a nice day ahead :)