WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#49743 closed task (blessed) (fixed)

Bump bundled theme versions for 5.4

Reported by: desrosj Owned by: desrosj
Milestone: 5.4 Priority: high
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Previously:

Looking at the changed files since 5.3.2, each bundled theme has changes and should receive a new version.

@ianbelanger is preparing a patch now.

Attachments (1)

49743.diff (54.1 KB) - added by ianbelanger 20 months ago.
Version bump

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
20 months ago

  • Description modified (diff)

#2 @SergeyBiryukov
20 months ago

  • Summary changed from Bump bundled theme versions to Bump bundled theme versions for 5.4

@ianbelanger
20 months ago

Version bump

#3 @SergeyBiryukov
20 months ago

  • Keywords has-patch added; needs-patch removed

For reference, Twenty Nineteen has some CSS changes from [47327] and [47339] after running the build task. These should be safe to backport to the branch.

#4 @SergeyBiryukov
20 months ago

In 47538:

Twenty Nineteen: Update style-editor.css and style-rtl.css after running the build task.

Follow-up to [47327], [47339].

Props ianbelanger.
Reviewed by desrosj, SergeyBiryukov.
Merges [47536] and [47537] to the 5.4 branch.
See #48526, #49410, #49743.

#5 @desrosj
20 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 47539:

Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4.

Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743.

#6 @desrosj
20 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

#7 @desrosj
20 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47540:

Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4.

Reviewed by desrosj, SergeyBiryukov.
Props ianbelanger, desrosj, SergeyBiryukov.
Merges [47539] to the 5.4 branch.
Fixes #49743.

#8 @superpoincare
20 months ago

The main stylesheet style.css now has dates as the version.

For example:

https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyseventeen/functions.php#L451

<?php
wp_enqueue_style( 'twentyseventeen-style', get_stylesheet_uri(), array(), '20190507' );

So the bump should also change the lines in functions.php

It doesn't affect all themes as some bundled themes like Twenty Nineteen and Twenty Twenty use the version in the stylesheet but for others it does.

Note: See TracTickets for help on using tickets.